Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/10#discussion_r64324484
--- Diff: src/protocols/rdp/rdp_settings.c ---
@@ -925,9 +925,31 @@ void guac_rdp_push_settings(guac_rdp_settings*
guac_settings, freerdp* rdp) {
/* Performance flags */
#ifdef LEGACY_RDPSETTINGS
+
+ /* Explicitly set flag value */
rdp_settings->performance_flags =
guac_rdp_get_performance_flags(guac_settings);
+
+ /* Set individual flags - some FreeRDP versions overwrite the above */
+ rdp_settings->smooth_fonts = guac_settings->font_smoothing_enabled;
+ rdp_settings->disable_wallpaper = !guac_settings->wallpaper_enabled;
+ rdp_settings->disable_full_window_drag =
!guac_settings->full_window_drag_enabled;
+ rdp_settings->disable_menu_animations =
!guac_settings->menu_animations_enabled;
+ rdp_settings->disable_theming = !guac_settings->theming_enabled;
+ rdp_settings->desktop_composition =
!guac_settings->desktop_composition_enabled;
--- End diff --
Meaning that you should remove the ! that inverts the setting here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
