Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/32#discussion_r71817845
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing/SecureRandomShareKeyGenerator.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.guacamole.auth.jdbc.sharing;
+
+import java.security.SecureRandom;
+import javax.xml.bind.DatatypeConverter;
+
+/**
+ * An implementation of the ShareKeyGenerator which uses SecureRandom to
+ * generate cryptographically-secure random sharing keys.
+ *
+ * @author Michael Jumper
+ */
+public class SecureRandomShareKeyGenerator implements ShareKeyGenerator {
+
+ /**
+ * Instance of SecureRandom for generating sharing keys.
+ */
+ private final SecureRandom secureRandom = new SecureRandom();
+
+ @Override
+ public String getShareKey() {
+ byte[] bytes = new byte[33];
--- End diff --
It's 33 because the key is output as base64, and thus needs to be a
multiple of 3 for each byte of the output to have meaning. If it were 32, there
would be one or more useless padding bytes at the end of the base64-encoded
result.
If the non-power-of-two thing makes you cringe, we could switch to 32 and
hex.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
