Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/56#discussion_r74694459
--- Diff: guacamole/src/main/webapp/app/index/config/indexRouteConfig.js ---
@@ -88,7 +88,7 @@ angular.module('index').config(['$routeProvider',
'$locationProvider',
// Otherwise, reject and reroute
else {
- $location.url(homePage.url);
+ $location.path(homePage.url);
--- End diff --
Yep. Lacking this change, URL parameters are wiped out when the user is
routed to their only connection.
Without the share key continuing to be present in the URL, reloading the
tab fails results in a login page rather than the connection they were just
using (a pretty severe violation of the [Principle of Least
Surprise](https://en.wikipedia.org/wiki/Principle_of_least_astonishment)).
Navigating back to the connection after visiting a different page would fail
for the same reason.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
