Github user jmuehlner commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-client/pull/94#discussion_r91015645
  
    --- Diff: 
extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/DuoAuthenticationProvider.java
 ---
    @@ -0,0 +1,100 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.guacamole.auth.duo;
    +
    +import com.google.inject.Guice;
    +import com.google.inject.Injector;
    +import org.apache.guacamole.GuacamoleException;
    +import org.apache.guacamole.net.auth.AuthenticatedUser;
    +import org.apache.guacamole.net.auth.AuthenticationProvider;
    +import org.apache.guacamole.net.auth.Credentials;
    +import org.apache.guacamole.net.auth.UserContext;
    +
    +/**
    + * AuthenticationProvider implementation which uses Duo as an additional
    + * authentication factor for users which have already been authenticated by
    + * some other AuthenticationProvider.
    + */
    +public class DuoAuthenticationProvider implements AuthenticationProvider {
    +
    +    /**
    +     * Injector which will manage the object graph of this authentication
    +     * provider.
    +     */
    +    private final Injector injector;
    +
    +    /**
    +     * Creates a new DuoAuthenticationProvider that verifies users
    +     * using the Duo authentication service
    +     *
    +     * @throws GuacamoleException
    +     *     If a required property is missing, or an error occurs while 
parsing
    +     *     a property.
    +     */
    +    public DuoAuthenticationProvider() throws GuacamoleException {
    +
    +        // Set up Guice injector.
    +        injector = Guice.createInjector(
    +            new DuoAuthenticationProviderModule(this)
    +        );
    +
    +    }
    +
    +    @Override
    +    public String getIdentifier() {
    +        return "duo";
    +    }
    +
    +    @Override
    +    public AuthenticatedUser authenticateUser(Credentials credentials)
    +            throws GuacamoleException {
    +        return null;
    +    }
    +
    +    @Override
    +    public AuthenticatedUser updateAuthenticatedUser(AuthenticatedUser 
authenticatedUser,
    +            Credentials credentials) throws GuacamoleException {
    +        return authenticatedUser;
    +    }
    +
    +    @Override
    +    public UserContext getUserContext(AuthenticatedUser authenticatedUser)
    +            throws GuacamoleException {
    +
    +        UserVerificationService authProviderService =
    --- End diff --
    
    Did you mean to leave this variable named "authProviderService"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to