Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/122#discussion_r101211030
--- Diff:
extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/ConfigurationService.java
---
@@ -0,0 +1,223 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.guacamole.auth.radius;
+
+import com.google.inject.Inject;
+import java.util.Collections;
+import java.util.List;
+import org.apache.guacamole.GuacamoleException;
+import org.apache.guacamole.environment.Environment;
+
+/**
+ * Service for retrieving configuration information regarding the RADIUS
server.
+ *
+ * @author Michael Jumper
+ */
+public class ConfigurationService {
+
+ /**
+ * The Guacamole server environment.
+ */
+ @Inject
+ private Environment environment;
+
+ /**
+ * Returns the hostname of the RADIUS server as configured with
+ * guacamole.properties. By default, this will be "localhost".
+ *
+ * @return
+ * The hostname of the RADIUS server, as configured with
+ * guacamole.properties.
+ *
+ * @throws GuacamoleException
+ * If guacamole.properties cannot be parsed.
+ */
+ public String getRadiusServer() throws GuacamoleException {
+ return environment.getProperty(
+ RadiusGuacamoleProperties.RADIUS_SERVER,
+ "localhost"
+ );
+ }
+
+ /**
+ * Returns the authentication port of the RADIUS server configured with
+ * guacamole.properties.
+ *
+ * @return
+ * The authentication port of the RADIUS server, as configured with
+ * guacamole.properties.
+ *
+ * @throws GuacamoleException
+ * If guacamole.properties cannot be parsed.
+ */
+ public int getRadiusAuthPort() throws GuacamoleException {
+ return environment.getProperty(
+ RadiusGuacamoleProperties.RADIUS_AUTH_PORT,
+ 1812
+ );
+ }
+
+ /**
+ * Returns the accounting port of the RADIUS server configured with
+ * guacamole.properties.
+ *
+ * @return
+ * The accouting port of the RADIUS server, as configured with
+ * guacamole.properties.
+ *
+ * @throws GuacamoleException
+ * If guacamole.properties cannot be parsed.
+ */
+ public int getRadiusAcctPort() throws GuacamoleException {
+ return environment.getProperty(
+ RadiusGuacamoleProperties.RADIUS_ACCT_PORT,
+ 1813
+ );
+ }
+
+ /**
+ * Returns the shared secret of the RADIUS server configured with
+ * guacamole.properties.
+ *
+ * @return
+ * The shared secret of the RADIUS server, as configured with
+ * guacamole.properties.
+ *
+ * @throws GuacamoleException
+ * If guacamole.properties cannot be parsed.
+ */
+ public String getRadiusSharedSecret() throws GuacamoleException {
+ return environment.getProperty(
+ RadiusGuacamoleProperties.RADIUS_SHARED_SECRET,
+ null
+ );
+ }
+
+ /**
+ * Returns the authentication protocol of the RADIUS server
+ * from guacamole.properties.
+ *
+ * @return
+ * The authentication protocol of the RADIUS server,
+ * from guacamole.properties.
+ *
+ * @throws GuacamoleException
+ * If guacamole.properties cannot be parsed.
+ */
+ public String getRadiusAuthProtocol() throws GuacamoleException {
+ return environment.getProperty(
+ RadiusGuacamoleProperties.RADIUS_AUTH_PROTOCOL,
+ null
+ );
+ }
+
+ /**
+ * Returns the number of retries for connecting to the RADIUS server
+ * from guacamole.properties.
+ *
+ * @return
+ * The number of retries for connection to the RADIUS server,
+ * from guacamole.properties.
+ *
+ * @throws GuacamoleException
+ * If guacamole.properties cannot be parsed.
+ */
+ public int getRadiusRetries() throws GuacamoleException {
+ return environment.getProperty(
+ RadiusGuacamoleProperties.RADIUS_RETRIES,
+ 5
+ );
+ }
+
+ /**
+ * Returns the timeout for connecting to the RADIUS server
+ * from guacamole.properties.
+ *
+ * @return
+ * The timeout for connection to the RADIUS server,
+ * from guacamole.properties.
+ *
+ * @throws GuacamoleException
+ * If guacamole.properties cannot be parsed.
+ */
+ public int getRadiusTimeout() throws GuacamoleException {
+ return environment.getProperty(
+ RadiusGuacamoleProperties.RADIUS_TIMEOUT,
+ 60
+ );
+ }
+
+ public String getRadiusCAFile() throws GuacamoleException {
--- End diff --
This and other functions here: missing JavaDoc comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
