Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/122#discussion_r110925515
--- Diff:
extensions/guacamole-auth-radius/src/main/resources/config/radiusConfig.js ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * Config block which registers Radius-specific field types.
+ */
+angular.module('guacRadius').config(['formServiceProvider',
+ function guacRadiusConfig(formServiceProvider) {
+
+ // Define field for the challenge from the RADIUS service
+
formServiceProvider.registerFieldType('GUAC_RADIUS_CHALLENGE_RESPONSE', {
+ module : 'guacRadius',
+ controller : 'radiusResponseController',
+ templateUrl : 'app/ext/radius/templates/radiusResponseField.html'
+ });
+
+ // Define the hidden field for the RADIUS state
+ formServiceProvider.registerFieldType('GUAC_RADIUS_STATE', {
+ module : 'guacRadius',
+ controller : 'radiusStateController',
+ template : '<input class="ng-hide" type=hidden ng-model="model"
/>'
--- End diff --
Seemed like overkill for as little text as it was, but I'll go for
consistency and move it out to a template file. Also removed ng-hide.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
