Github user mike-jumper commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-client/pull/206#discussion_r147559637
  
    --- Diff: 
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/conf/PrivateKeyGuacamoleProperty.java
 ---
    @@ -60,6 +60,7 @@ public PrivateKey parseValue(String value) throws 
GuacamoleServerException {
                 for (int readBytes; (readBytes = keyStreamIn.read(keyBuffer)) 
!= -1;)
                     keyStreamOut.write(keyBuffer, 0, readBytes);
     
    +            keyStreamIn.close();
    --- End diff --
    
    If `write()` throws an exception, then this line will never be reached. 
You'll need something like:
    
    ```
    try {
        // write() loop here
    }
    finally {
        keyStreamIn.close();
    }


---

Reply via email to