[
https://issues.apache.org/jira/browse/HAMA-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714665#comment-13714665
]
Edward J. Yoon commented on HAMA-767:
-------------------------------------
I can't apply your patch. Please use the TRUNK.
{code}
edward@udanax:~/workspace/hama-trunk$ patch -p0 < HAMA-767-v4-fixed.patch
patching file examples/src/main/java/org/apache/hama/examples/DynamicGraph.java
patching file
examples/src/test/java/org/apache/hama/examples/DynamicGraphTest.java
patching file examples/src/test/resources/dg.txt
patching file graph/src/main/java/org/apache/hama/graph/AggregationRunner.java
patching file
graph/src/main/java/org/apache/hama/graph/CountVerticesPeerAggregator.java
patching file graph/src/main/java/org/apache/hama/graph/DiskVerticesInfo.java
patching file
graph/src/main/java/org/apache/hama/graph/FinishPeerAggregator.java
patching file graph/src/main/java/org/apache/hama/graph/GraphJobRunner.java
Hunk #5 FAILED at 254.
Hunk #6 succeeded at 260 (offset -3 lines).
Hunk #7 succeeded at 325 (offset -3 lines).
Hunk #8 succeeded at 362 with fuzz 2 (offset -3 lines).
Hunk #9 succeeded at 434 (offset -3 lines).
Hunk #10 succeeded at 518 (offset -3 lines).
Hunk #11 succeeded at 531 (offset -3 lines).
Hunk #12 succeeded at 548 (offset -3 lines).
Hunk #13 succeeded at 669 (offset -3 lines).
1 out of 13 hunks FAILED -- saving rejects to file
graph/src/main/java/org/apache/hama/graph/GraphJobRunner.java.rej
patching file graph/src/main/java/org/apache/hama/graph/ListVerticesInfo.java
patching file graph/src/main/java/org/apache/hama/graph/PeerAggregator.java
patching file graph/src/main/java/org/apache/hama/graph/Vertex.java
patching file graph/src/main/java/org/apache/hama/graph/VertexInterface.java
patching file graph/src/main/java/org/apache/hama/graph/VerticesInfo.java
{code}
{quote}
Should I make a new ticket and explain what I'm thinking about aggregators?
{quote}
Sorry but, if possible, please add only vertex add/remove methods and necessary
changes as a first version. And then, let's commit it to TRUNK. I'll check
whether it works correctly on fully distributed mode. If you finish the
documentation of new APIs you've added, I'm sure that your GSoC will be
finished successfully. :-)
And yes, please create new ticket (with explanation) for code refactoring.
According to my experiences of open source development, that's the right way.
Let's consider what should be refactored, deprecated or removed together.
> [GSoC 2013] Vertex addition and removal
> ---------------------------------------
>
> Key: HAMA-767
> URL: https://issues.apache.org/jira/browse/HAMA-767
> Project: Hama
> Issue Type: New Feature
> Components: examples, graph
> Affects Versions: 0.6.2
> Reporter: Anastasis Andronidis
> Assignee: Anastasis Andronidis
> Labels: dynamic, graph, gsoc, gsoc2013, mentoring
> Fix For: 0.6.3
>
> Attachments: HAMA-767-v4-fixed.patch, HAMA-767-v4.patch
>
>
> Implement addVertex and removeVertex methods for incremental graph support on
> Graph API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
