On 1/23/07, Alexei Zakharov <[EMAIL PROTECTED]> wrote:
Hi Andrew, > 1. > I have no objection to with or without setting init cause for this case. IMO it is ok for us to be more informative than RI. > 2. NIO dependency. Because java.io.Reader is introduced in test case. If NIO > is not added in mf file, you'll see compile error in eclipse. Well, it is not a problem to commit this. But, WHY NIO? I thought java.io.Reader is a part of luni module. Am I wrong?
No, you're not wrong. But java.nio.CharBuffer is involved in java.io.Reader. That's why I added nio in sql manifset. You can see the compile error in Eclipse without nio dependency. Or any other way to solve this problem? Thanks,
2007/1/23, Andrew Zhang <[EMAIL PROTECTED]>: > Hi Alexei, > > Thanks for your suggestion. Please see my answers on the two questions: > > 1. Set IOException as the cause of SerialException. Yes, it does make sense. > But test case shows that RI doesn't do it for this case. The stace trace > looks like following without any "caused by": > javax.sql.rowset.serial.SerialException: SerialClob: null > at javax.sql.rowset.serial.SerialClob.<init>(SerialClob.java:145) > I have no objection to with or without setting init cause for this case. > > 2. NIO dependency. Because java.io.Reader is introduced in test case. If NIO > is not added in mf file, you'll see compile error in eclipse. > > Please let me know if there's any problem. :) Thanks a lot! > > On 1/23/07, Alexei Zakharov (JIRA) <[EMAIL PROTECTED]> wrote: > > > > > > [ > > https://issues.apache.org/jira/browse/HARMONY-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466504 ] > > > > Alexei Zakharov commented on HARMONY-3017: > > ------------------------------------------ > > > > BTW, why you've made it dependent on NIO? > > > > > [classlib][sql] Implementation for SerialClob > > constructors,getCharacterStream(), and length() methods. > > > > > ------------------------------------------------------------------------------------------------------ > > > > > > Key: HARMONY-3017 > > > URL: https://issues.apache.org/jira/browse/HARMONY-3017 > > > Project: Harmony > > > Issue Type: New Feature > > > Components: Classlib > > > Reporter: Andrew Zhang > > > Assigned To: Alexei Zakharov > > > Attachments: patch.diff > > > > > > > > > Hi, > > > I'll upload the implementation for SerialClob > > constructors,getCharacterStream(), and length() methods soon. > > > Best regards, > > > Andrew > > > > -- > > This message is automatically generated by JIRA. > > - > > If you think it was sent incorrectly contact one of the administrators: > > https://issues.apache.org/jira/secure/Administrators.jspa > > - > > For more information on JIRA, see: http://www.atlassian.com/software/jira -- Alexei Zakharov, Intel ESSD
-- Best regards, Andrew Zhang
