Good - the key to #1 is "should" - we shouldn't reject a patch just
because someone didn't do that.
geir
On Feb 5, 2007, at 11:10 AM, Alexey Petrenko wrote:
Guys,
I think we need a little update for the "Good issue resolution
guideline" [1]
I suggest the following additions to the "Resolving Issues.If the
issue is a bug" to make committers life much easier :)
1. All the newly introduced message strings should be
internationalized
2. All the patches should have an evaluation comment
3. If you change two lines of code please make sure that you patch
includes only these two lines and do not include any other changes
like code formatting.
4. Add yourself to the list of watchers to receive comments and
concerns on your patch.
Thoughts? Concerns? Objections?
SY, Alexey
[1] http://harmony.apache.org/issue_resolution_guideline.html
