2007/3/27, Gregory Shimansky <[EMAIL PROTECTED]>:
Vladimir Ivanov wrote:
> On 3/27/07, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
>> How to fix it in SVN?
I've fixed this in 522890.
Thanks!
The commit for HARMONY-3485 added a local
variable that isn't used. GCC 4.1.1 produced a warning for this variable
initialization that I reproduced on my Gentoo installation. BTW GC_GEN
doesn't build on GCC 4.1.1 too but I don't really know how to fix.
Xiao-Feng, could you please take a look at it?
>> Do we have a CC configuration that caught this problem?
>
> Actually, no. We have CC on top of SUSE 9 with gcc 3.3.3. And it
> reports 'passed' status.
I've suggested to upgrade the testing target for CC some time ago in
[1]. It would really help to catch warnings produced by modern
compilers. GCC 3.3.3 is more than 3 years old and most people use
distributions with newer versions.
[1] http://article.gmane.org/gmane.comp.java.harmony.devel/21903
>> Thanks,
>> Mikhail
>>
>> 2007/3/27, Pavel Pervov <[EMAIL PROTECTED]>:
>> > Matt,
>> >
>> > I expect I'm missing an obvious setup issue for the X86_64
>> > > environment.
>> >
>> >
>> > Most probably, you don't. This was introduced by the commit [1].
>> >
>> >
>> >
>> > > If y'all have a suggestion that would be most excellent.
>> >
>> >
>> > As I see from the code, you can safely remove this line. This
>> variable is
>> > not used anywhere.
>> >
>> > [1]
>> >
>>
http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/vm/vmcore/src/init/finalizer_thread.cpp?view=diff&r1=521689&r2=521690
>>
>> > WBR,
>> > --
>> > Pavel Pervov,
>> > Intel Enterprise Solutions Software Division
>> >
>>
>
--
Gregory
