Xiao-Feng's solution have a minimal possible diff. +1 from me.
On 5/16/07, George Timoshenko <[EMAIL PROTECTED]> wrote:
Xiao-Feng Li wrote: > George, is it possible to reuse the same function and let it to return > different flags for the purpose, such as NEVER_INTERRUPTIBLE, > SOMETIMES_INTERRUPTIBLE, ALWAYS_INTERRUPTIBLE? Yes. This is also suitable for me. In this case VM-JIT interface will be extended with one more enum structure instead of additional method. > > Thanks, > xiaofeng > > On 5/15/07, George Timoshenko <[EMAIL PROTECTED]> wrote: >> Some time ago 'vm_helper_is_gc_interruptible' method appeared in the >> interface. It is used in JIT to identify if a helper call can be >> interrupted by gc for enumeration. And if a helper is interruptible in >> some circumstances and is not interruptible in other cases the methods >> returns TRUE, as GC-support in JIT must be ready to provide data for gc. >> (for example there are monitor enter/exit helpers with such behavior) >> >> Another JIT functionality (BBPolling) needs to know if a helper call can >> be interrupted for sure. So that method (vm_helper_is_gc_interruptible) >> can not be used as is. >> >> My suggestion is to extend VM-JIT interface with one more method >> 'vm_helper_is_interruptible' that returns true if a helper can be >> interrupted for sure. >> >> Possible implementation is attached to HARMONY-2057 >> (https://issues.apache.org/jira/browse/HARMONY-2057) >> >> What do you think about it? >> >> > >
-- Mikhail Fursov
