As we discussed the source of the errror is incorrect comparator. However, I can suggest a patch to Arrays which makes Arrays.sort() slightly close to RI. With the patch sorting algorithm is not changed, but ArraysSortTest.java is passed as on RI. The patch is attached to the issue.
On 5/16/07, Aleksey Ignatenko <[EMAIL PROTECTED]> wrote:
From H-3339 comment: As the bug is in the tests then it is to be filed on Eclipse and this JIRA closed with comment about Eclipse bug. Please, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=176157 as example of Harmony related bug. BR, Aleksey Ignatenko. On 5/15/07, Sergey Kuksenko <[EMAIL PROTECTED]> wrote: > > Hi All, > > As you wrote in the JIRA the reason of failure is incorrect Comparator > which > is used in the test. > The Comparator violates the follwing rule from specification: > "The implementor must ensure that sgn(compare(x, y)) == > -sgn(compare(y, x))for all > x and y." > So I thing that It would be more correct to fix a comparator from test. > > Some words about bug2bug compatibility. The fact that RI has different > result on this comparator means nothing, because in case of different > incorect comparator RI may give a different unpredictable results. So > should > we check *all possible set of incorrect comparators* and move exactly in > same results as done by RI? > I think that it will mean that we should have completely the same > implementation of sorting. > > > > On 5/15/07, Eugene Ostrovsky <[EMAIL PROTECTED]> wrote: > > > > Hi all. > > > > Some of eclipse tests pass on RI but fail on harmony. See > > *HARMONY-3339<https://issues.apache.org/jira/browse/HARMONY-3339> > > * . > > The tests are incorrect. They pass on RI due to difference in > > implementation > > of Arrays.sort() method. > > > > Shall we alter our Array.sort() implementation to be consistent with RI > > ant > > to make these buggy tests pass? > > > > Thanks, > > Eugene. > > > > > > -- > Best regards, > --- > Sergey Kuksenko. > Intel Enterprise Solutions Software Division. >
-- Best regards, --- Sergey Kuksenko. Intel Enterprise Solutions Software Division.
