On 6/27/07, Tim Ellison <[EMAIL PROTECTED]> wrote:
Stepan Mishura wrote:
> On 6/27/07, Nina Rinskaya wrote:
>> Hi all,
>>
>> It looks that r549864 commit has introduced a regression:
>>
>
> I think it's too risky to rollback the commit. It looks like
> (according to the evaluation) that the impact of the regression is
> low. So I wouldn't fix it in M2. I think we should mention the issue
> in milestone's release notes and fix it after M2. Objections?
Do we know how to fix it? Weldon? It may be worth considering the
impact of the fix.
I recommend we do not fix this bug in M2. This is based on looking at
org.eclipse.team.tests.ccvs.core.subscriber.* source code for 20 minutes.
Its probably 2+ days work just to get the unit test to run standalone and
exhibit the failure frequently enough to start debugging. Then 2+ days to
develop a patch. And finally a few days to run all M2 regression tests to
verify the new patch does not introduce new bugs. This takes us way past
the deadline for M2.
Regards,
Tim
>
org.eclipse.team.tests.ccvs.core.subscriber.testConcurrentAccessToSyncSettestcase
>
>> from Eclipse Unit Tests ('teamcvs' suite) intermittently crashes on
>> Windows 2003 (x86) with the following output:
>>
>> [java] Windows reported exception: 0xc0000005
>> [java] Registers:
>> [java] EAX: 0x00410048, EBX: 0x140e9870, ECX: 0x000022a2, EDX:
>> 0x00383f30
>> [java] ESI: 0x16e3ed0c, EDI: 0x0b3943f0, ESP: 0x10d6fa78, EBP:
>> 0x13f461f4
>> [java] EIP: 0x1000430c
>> [java] Stack trace:
>> [java] 0: hythread_thin_monitor_exit (??:-1)
>> [java] <end of stack trace>
>>
>> The testcase deals with synchronized resources, and probably the crash
>> happens whyle adding ~1000-5000th element to the synchronized
collection.
>>
>> The issue impacts only 1 testcase, but the whole suite (170 tests) is
>> reported as crashed, it reduces EUT pass rate by 0,4%.
>>
>> The issue was not found earlier because it is an intermittent issue
>> (but it
>> is often reproducible, ~3 times per 5 runs).
>>
>> Thanks.
>>
>> --
>> Nina
>>
>> On 6/24/07, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
>> >
>> > We have passed our code freeze date for M2
>> >
>> > Last time we executed Tim's policy that each commit should have
>> > approval from two committers, let's follow the same way -- no more
>> > commits please, without agreement from two committers on the dev
list.
>> >
>> > Now let's test what we have and see if any critical bugs were
>> > introduced just before the code freeze. Please raise anything you
>> > think is critical/blocker for consideration.
>> >
>> > Thanks,
>> > Mikhail
>
--
Weldon Washburn
