On 7/11/07, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
Do we have original contribution saved somewhere? For some reason "manage attachments" links says for me that this JIRA does not exist any more I guess if we don't have the original bundle we should restart the vote Thanks, Mikhail 2007/7/11, Tim Ellison <[EMAIL PROTECTED]>: > Mikhail Loenko wrote: > > 2007/7/10, Tim Ellison <[EMAIL PROTECTED]>: > >> Mikhail Loenko wrote: > >> > We now have all requisite paperwork in place for > >> > http://issues.apache.org/jira/browse/HARMONY-4266, so let's vote to > >> accept: > >> > > >> > [ ] +1 Accept this contribution > >> > [ ] -1 Reject because... > >> > > >> > As usual, 3 days unless someone complains they need more time. > >> > >> I'd like a bit more time to look through the code please. > >> > >> A minor observation is that the ASF block comments in each file need > >> updating to the new format [1] (without the Copyright line). > >> > >> One of the attached patches [2] has a copy of > >> PRTI/setup/src/PRTIJUnitTestRunner/JUnitTask.java probably by mistake, > >> as I don't think it has been written by the contributor. > >> > >> Nothing fatal, but I'd like to spend a bit more time (a couple of days) > >> looking through it. > > > > Sure, > > > What are we voting on?! that JIRA's attachments seem to keep changing! > > I suggest we focus on the original contribution that we have received > the paperwork for, and that new work is attached to a new JIRA issue. > > Regards, > Tim >
Tim, Mikhail, Sorry for putting you to confusion. The original contribution archive is prti.zip. It's still here https://issues.apache.org/jira/browse/HARMONY-4266. Others are merely patches which I created as an individual contributor. It is not a bulk contribution. Nevertheless, what should I do to make voting successful? Thanks, Alexei.
