I see the commit went in as r713673. Are you done now, can we resume testing this build?
Regards, Tim chunrong lai wrote: > Colleagues: > Thanks a lot for your advices and discussions. > I think that I got enough support to enable null-check inside the VM > helper. I will commit it and upload a new snapshot soon. > > On Thu, Nov 13, 2008 at 3:05 PM, bu qi cheng <[EMAIL PROTECTED]> wrote: > >> Hi Mikhail >> >> Can you show us where is the magic for the monitorEnter? The eliminate >> the chknull, the HLR magic is needed. >> >> Buqi >> >> On Thu, Nov 13, 2008 at 2:25 PM, Mikhail Fursov <[EMAIL PROTECTED] >>> wrote: >>> AFAIR checknull is always precedes an operation that can cause exception >> if >>> one of its arguments is NULL. Since this operation may have side effects >> - >>> it can't be removed nor moved into try/cactch block by optimizer. >>> In our case if the operation is a helper-call - it must fit this scheme: >> do >>> manual nullcheck. >>> >>> There should not be any performance problem here: if the helper is hot -> >>> Jitrino.OPT will inline it using magics and eliminate the check. >>> So I see no problems enabling null-check inside of the VM helper. >>> >>> -- >>> Mikhail Fursov >>> >
