Well, I would say it was pretty well formatted.

The thing I don't like about this class is a mess of different
security applications which cannot be deducted from naming. The class
would be easier to understand if split into four appropriately named
actions. This would also help renaming arg1, arg2 fields into
something readable.



On Tue, Dec 23, 2008 at 12:42 PM, Kevin Zhou <[email protected]> wrote:
> Is this PriviAction really an ugly class?
>



-- 
С уважением,
Алексей Федотов,
ЗАО «Телеком Экспресс»

Reply via email to