Oliver Deakin wrote: > All the tests pass for me except 2 errors and 8 failures in the > concurrent tests. I don't know if theyre new or not - does anybody else > see them?
I see some of these too (see HARMONY-6137). Are they regressions or do these fail for you the same way on M8? I still have a mind to press ahead with declaring M9 and opening the code up again for new fixes. So I'm going to focus only on regressions for now. Regards, Tim > AbstractQueuedSynchronizerTest > testAcquireInterruptibly1 > > AtomicLongArrayTest > testCompareAndSet > testCountingInMultipleThreads > > AtomicLongFieldUpdaterTest > testCompareAndSet > > AtomicLongTest > testCompareAndSet > > FutureTaskTest > testTimedGet_InterruptedException2 > > LinkedBlockingQueueTest > testTimedOffer > > ReentrantLockTest > testLockInterruptibly1 > testAwaitUninterruptibly > > ReentrantReadWriteLockTest > testAwaitUninterruptibly > > It looks like some of them failed in M8 [1], and most appear to be > intermittent (I sometimes get a different set of failures from one run > to the next). They fail on both J9 and DRLVM. > > Regards, > Oliver > > [1] > http://mail-archives.apache.org/mod_mbox/harmony-dev/200811.mbox/%[email protected]%3e > > > > Tim Ellison wrote: >> Regis wrote: >> >>> Tim Ellison wrote: >>> >>>> With this patch applied all the tests pass for me on Windows and Linux. >>>> >>>> I have not figured out why we have this function that doesn't go >>>> through >>>> the port library, and therefore doesn't deal with the invalid file >>>> handles and interrupts etc. properly. >>>> >>>> Since this is the minimal patch to fix M9, I propose we go with this, >>>> and then continue the networking code tidy up in the next phase. >>>> >>>> I'm looking for people to test this patch and a committer to approve it >>>> being applied to the code base now. >>>> >>> +1 >>> It passed all luni and rmi tests on Ubuntu 8.04.2. >>> >> >> Thanks. >> >> I've applied the patch at r761237. >> >> I'll wait a short time to let people do additional testing before >> calling for the M9 vote. Fingers and toes crossed now <g>. >> >> Regards, >> Tim >> >> >> >
