Thanks, Regis. On Thu, Apr 16, 2009 at 5:49 PM, Regis <[email protected]> wrote:
> Kevin Zhou wrote: > >> Previously, it is proved by using benchmarks like Specjbb. >> Since it's been a long time I don't really remember the accurate >> statistics >> of how much improvements it brings. >> > All right, I will try to write some micro benchmarks :) > > >> On Thu, Apr 16, 2009 at 5:18 PM, Regis Xu (JIRA) <[email protected]> wrote: >> >> [ >>> >>> https://issues.apache.org/jira/browse/HARMONY-6045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699595#action_12699595 >>> ] >>> >>> Regis Xu commented on HARMONY-6045: >>> ----------------------------------- >>> >>> Hi Kevin, >>> >>> This patch is interesting, do you have any benchmark to prove the >>> improvement? >>> >>> [classlib] [luni] Optimize java.lang.String.toUpperCase(), >>>> >>> String.toLowerCase() and String sharing for more performance gains >>> >>> ----------------------------------------------------------------------------------------------------------------------------- >>> >>>> Key: HARMONY-6045 >>>> URL: https://issues.apache.org/jira/browse/HARMONY-6045 >>>> Project: Harmony >>>> Issue Type: Improvement >>>> Components: Classlib >>>> Affects Versions: 5.0M8 >>>> Reporter: Kevin Zhou >>>> Fix For: 5.0M9 >>>> >>>> Attachments: HARMONY-6045.diff >>>> >>>> Original Estimate: 24h >>>> Remaining Estimate: 24h >>>> >>>> Recently, I make some improvement on java.lang.String and >>>> >>> java.lang.AbstractStringBuilder class for more performance gains. >>> >>>> 1. Move the share mode for all the AbstractStringBuilder.append method, >>>> >>> since the append never change the share things. >>> >>>> 2. Move the share mode in AbstractStringBuilder.setLength method >>>> 3. Add the special care for the ASCII things, especially on case things >>>> >>> of String.toUpperCase and to LowerCase methods. >>> >>> -- >>> This message is automatically generated by JIRA. >>> - >>> You can reply to this email to add a comment to the issue online. >>> >>> >>> >> > > -- > Best Regards, > Regis. >
