I've added a test case for this patch to avoid future regression. Best Regards Sean, Xiao Xia Qiu
2009/5/22 Tim Ellison <[email protected]>: > Looks like you have some code in the JIRA that can be trivially turned > into a test case too. > > I say go ahead and commit it Sean. > > Regards, > Tim > > Sean Qiu wrote: >> Yeap, user is important to us. lol >> >> Thanks for reviewing. >> >> Best Regards >> Sean, Xiao Xia Qiu >> >> >> >> >> 2009/5/22 Tim Ellison <[email protected]>: >>> Oliver Deakin wrote: >>>> And a follow up reminder - we are now in code freeze and testing period, >>>> aiming to publish M10 on Friday 29th May. >>>> >>>> As usual, defining a bug as "must-fix" in this milestone requires (at >>>> least) two committers agreement. Please raise test failures on the list >>>> and open JIRAs where appropriate. >>> What time does the code freeze start today ;-) ? >>> >>> I'd like to propose that HARMONY-6074 patch is applied since it is >>> blocking Maven. The patch looks fine to me. >>> >>> Regards, >>> Tim >>> >>> >>>> Tim Ellison wrote: >>>>> Just a reminder. We are entering feature freeze now, and there is just >>>>> one week left to go to our code freeze date. >>>>> >>>>> No major new functionality gets dropped in from now until after M10. >>>>> Point bug fixes are still ok, and if you have time to do some testing >>>>> and fixing ahead of the test phase all the better. >>>>> >>>>> Feature freeze Fri 15th May >>>>> Code freeze Fri 22nd May >>>>> Publish Fri 29th May >>>>> >>>>> With the 'customary' definitions of what they mean. >>>>> >>>>> Issues that *must* be fixed for M10 are tracked in JIRA using the 'Fix >>>>> for' field. From the Harmony JIRA homepage [1] click on the "5.0M10" >>>>> package listed in the Versions column to see those targeted for M10. >>>>> >>>>> [1] http://issues.apache.org/jira/browse/HARMONY >>>>> >>>>> Regards, >>>>> Tim >>>>> >>>>> >>>>> >> >
