No problem Mark!
I was seeing a missing symbol reported [1] when we linked the nio_char
library, but because we use the /FORCE:UNRESOLVED option we went ahead
with the link anyway and built the libraries, hence did not get a build
break for this. I did not see any runtime failure from this, but I
wouldn't expect to unless I used the particular charset with the failing
symbol (GB18030).
Is there a particular reason we use the /FORCE:UNRESOLVED option? It
feels like it might do more harm than good...
Regards,
Oliver
[1] GB18030.obj : error LNK2019: unresolved external symbol
_vmi_getvmifromjni...@4 referenced in function _unLinear
Mark Hindess wrote:
Thanks Oliver!
Oops. I meant to fix the windows makefiles before checking in the
luni/build.xml guess it slipped my mind.
BTW, what was the effect of the missing vmi link for nio_char?
Regards,
-Mark.
In message <[email protected]>, [email protected]
writes:
Author: odeakin
Date: Fri Jun 26 11:09:30 2009
New Revision: 788654
URL: http://svn.apache.org/viewvc?rev=788654&view=rev
Log:
Remove fdlibm links where they are unnecessary in Windows makefiles, fixing W
indows build broken by r788490. Also add missing link to vmi lib for nio_char
module.
--
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
