Mark Hindess wrote:
<SNIP!>
I notice that there are '$Revision...' tags in over 3k files in classlib
alone but since we don't have svn keyword expansion enabled (and I hope
we never do) then most are either not expanded or they were expanded
elsewhere and are just misleading in the context of our svn repository.
I suggest we remove them?
+1 to removing the revision tags - I don't think they are any use at the
moment, not just because they don't get expanded but also because they
don't cover all files.
Regards,
Oliver
(I'd rather not see author tags either but I'm not sure everyone agrees
with this. There is some discussion in the list archives.)
[snip]
Modified: modules/luni/src/main/native/luni/windows/helpers.c
--- modules/luni/src/main/native/luni/windows/helpers.c (original)
+++ modules/luni/src/main/native/luni/windows/helpers.c Thu Aug 6 01:02:29 2009
@@ -25,12 +25,14 @@
#include <windows.h>
#include <winbase.h>
#include <stdlib.h>
+#include <stdio.h>
#include <LMCONS.H>
#include <direct.h>
I don't have a windows machine configured to build Harmony right now but I
suspect that stdio.h was only required for your debugging and can/should
be removed from any patches/commits?
Regards,
Mark.
--
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
