On 30/Sep/2009 15:40, Mark Hindess wrote: > I see lots of "Trying to override old definition of datatype findbugs" > warnings. Is there a global that changes value embedded in the macro?
I see one (not "lots"?) but anyway it is fixed at r820328. Thanks, Tim > In message <4ac36437.9090...@googlemail.com>, Oliver Deakin writes: >> Thanks Tim - just gave it a test and it worked perfectly for me. Im +1 >> to extending it to other modules. >> >> Regards, >> Oliver >> >> Tim Ellison wrote: >>> Heads up that I've committed a new dependency on FindBugs[1], and >>> created a new target for running it. >>> >>> To keep it short enough to review, I only extended it to LUNI initially. >>> Even that raised a couple of questions in my mind for including it in >>> the top-level targets. Once we are happy with it I'll create the >>> targets in the other modules. >>> >>> Comments welcome. >>> >>> [1] http://findbugs.sourceforge.net/ >>> >>> Regards, >>> Tim >>> >>> On 30/Sep/2009 11:40, telli...@apache.org wrote: >>> >>>> Author: tellison >>>> Date: Wed Sep 30 10:40:03 2009 >>>> New Revision: 820236 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=820236&view=rev >>>> Log: >>>> Create a top-level "findbugs" target for modules, to run the UMD FindBugs >> static analysis tool. >>>> Currently only extended to the LUNI module until the approach is validated >> . >>>> Added: >>>> harmony/enhanced/classlib/trunk/modules/luni/make/findbugs-exclude-fil >> ter.xml (with props) >>>> Modified: >>>> harmony/enhanced/classlib/trunk/build.xml >>>> harmony/enhanced/classlib/trunk/depends/oss/ (props changed) >>>> harmony/enhanced/classlib/trunk/make/build-test.xml >>>> harmony/enhanced/classlib/trunk/make/depends.properties >>>> harmony/enhanced/classlib/trunk/make/depends.xml >>>> harmony/enhanced/classlib/trunk/make/properties.xml >>>> harmony/enhanced/classlib/trunk/modules/luni/build.xml >>>> >>> >>> >> -- >> Oliver Deakin >> Unless stated otherwise above: >> IBM United Kingdom Limited - Registered in England and Wales with number 7415 >> 98. >> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU >> > > >
