On 10/Nov/2009 06:14, enh wrote: > Is noone concerned about pooping this ebcdic cruft all over the place? > Shouldn't it be factored out into an isNewline method somewhere?
Where are they all? A grep of the code, which admittedly is likely to miss some cases shows the following (not counting test, native, and generated code) 0x15 luni/src/main/java/java/io/PrintStream.java \u0085 luni/src/main/java/java/util/Scanner.java regex/src/main/java/java/util/regex/AbstractLineTerminator.java regex/src/main/java/java/util/regex/EOLSet.java regex/src/main/java/java/util/regex/Lexer.java regex/src/main/java/java/util/regex/MultiLineEOLSet.java Do we have a problem? Regards, Tim > On Nov 9, 2009 10:10 PM, "Ray Chen" <[email protected]> wrote: > > Shall we store the return value of out.position()-1 to avoid invoking it > twice? > If it is too tiny for performace improvement, current patch seems good for > me. > > On Tue, Nov 10, 2009 at 2:04 PM, Regis <[email protected]> wrote: > Ray > Chen wrote: > >> Hi Regis... > -- > Regards, > > Ray Chen >
