Hi Mark,
It would be fine.
2010/9/20 Mark Hindess <mark.hind...@googlemail.com>
>
> In message <aanlktikq9fnp6wlida8myjh=b5v1dmherpjtcx6rs...@mail.gmail.com>,
> "Jimmy,Jing Lv" writes:
> >
> > Depends fixed.
>
> Actually, I missed your note and had already fixed the dependency in
> r998812 which adds the dependency to the x-tools module that uses ecj
> rather than at the top-level. I am trying to move away from top-level
> dependencies so if you don't mind I'll revert your change r998819?
>
> Regards,
> Mark.
>
> > 2010/9/20 Jimmy,Jing Lv <firep...@gmail.com>
> >
> > > Hi,
> > >
> > > I've committed the source and fixed the build.xml. However now
> > > it lacks ecj-3.5.1.jar to build. I find it in common-source but not
> > > in depends. Will update it.
> > >
> > > 2010/9/20 Mark Hindess <mark.hind...@googlemail.com>
> > >
> > >
> > >> In message <4c95f1c1.8010...@googlemail.com>, Oliver Deakin writes:
> > >> >
> > >> > Hi Jimmy,
> > >> >
> > >> > It looks like the x-tools commit broke the build - I'm guessing
> > >> > the ecj jars need to be added to the compiler classpath?
> > >>
> > >> I don't think it is that simple. It looks like it requires
> > >> javax.lang.model package to be implemented too or at least stubs?
> > >>
> > >> I've added a build.x.tools flag (that defaults to false) to allow
> > >> the builds to complete and progress to be made on fixing/testing
> > >> the new code.
> > >>
> > >> -Mark.
> > >
> > > --
> > >
> > > Best Regards!
> > >
> > > Jimmy, Jing Lv
> >
> > --
> >
> > Best Regards!
> >
> > Jimmy, Jing Lv
> > China Software Development Lab, IBM
>
>
>
--
Best Regards!
Jimmy, Jing Lv
China Software Development Lab, IBM
