Jesse, I'm trying to understand best coding practices. Do you mean replacing assertTrue to assertEquals for assertions like a = b? isAvailable() assertions still may be implemented via assertTrue?
-- With best regards / с наилучшими пожеланиями, Alexei Fedotov / Алексей Федотов, http://dataved.ru/ +7 916 562 8095 On Tue, Oct 5, 2010 at 3:09 AM, Jesse Wilson <jessewil...@google.com> wrote: > Harmony Folks, > > I'm planning to do some work on the Harmony 6 tests. I'm planning to do > small improvements: isolating tests for security managers, replace > assertTrue() with assertEquals(), etc. This work will be driven by me trying > to get Android's class library passing Harmony's tests as they appear in > SVN. Currently we only run our own forked copy; that's lame and it doubles > our maintenance burden. > > In which branch should I commit these changes? If I commit to the Java 5 > branch, then the changes benefit both development trees. I'm not personally > interested in Java 5 anymore, but I can't speak for everyone. But if I > commit to the Java 6 branch, I can immediately take advantage of the > changes. I don't want to think about Java 5 and I'm always running the > complete set of Java 6 tests. > > Any guidance? > > Thanks. > > -- > Android libcore team. > office hours <https://sites.google.com/a/google.com/dalvik/office-hours>every > afternoon, 1–5pm >
