----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/76/#review86 -----------------------------------------------------------
src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java <http://review.hbase.org/r/76/#comment472> This test is pretty long and tests quite a few different things. Consider to break it down into multiple smaller unit tests. src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java <http://review.hbase.org/r/76/#comment473> I'm not sure to understand why this test is named like that. Could you comment this test a bit more to explain what the intent is? src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java <http://review.hbase.org/r/76/#comment474> This seems brittle to me. src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java <http://review.hbase.org/r/76/#comment475> ? src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java <http://review.hbase.org/r/76/#comment476> I believe this method can be made `static'. src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java <http://review.hbase.org/r/76/#comment477> Copyright header. src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java <http://review.hbase.org/r/76/#comment486> I'm not a big fan of this. src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java <http://review.hbase.org/r/76/#comment478> private. src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java <http://review.hbase.org/r/76/#comment479> Do you really need to define the 3 following empty methods? src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java <http://review.hbase.org/r/76/#comment484> Consider writing a comment explaining what this test does. src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java <http://review.hbase.org/r/76/#comment480> Missing space before `conf'. src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java <http://review.hbase.org/r/76/#comment481> +"" is an idiom I don't like. src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java <http://review.hbase.org/r/76/#comment482> Missing spaces. src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java <http://review.hbase.org/r/76/#comment483> Missing spaces. src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java <http://review.hbase.org/r/76/#comment485> Don't do this. src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java <http://review.hbase.org/r/76/#comment487> Don't do this. src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java <http://review.hbase.org/r/76/#comment488> Why protected? src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java <http://review.hbase.org/r/76/#comment489> Is this really needed? src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java <http://review.hbase.org/r/76/#comment490> I don't understand why you're doing +=2 and /2 instead of just setting the upper bound of the loop to BATCH_SIZE/2. src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java <http://review.hbase.org/r/76/#comment491> Missing space before `scanRes'. src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java <http://review.hbase.org/r/76/#comment492> Why protected? src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java <http://review.hbase.org/r/76/#comment493> ? src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java <http://review.hbase.org/r/76/#comment494> Uh? Manual loop unrolling? - Benoit On 2010-05-26 18:09:30, Jean-Daniel Cryans wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/76/ > ----------------------------------------------------------- > > (Updated 2010-05-26 18:09:30) > > > Review request for hbase. > > > Summary > ------- > > This is HBASE-2223 AKA Replication 2.0, it is currently only a "preview > patch" as it's pretty much feature complete, works on a cluster, has unit > tests and whatnot, but it could use a lot more testing and cleaning and ideas > from others. > > > This addresses bug HBASE-2223. > http://issues.apache.org/jira/browse/HBASE-2223 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/HConstants.java 13aff26 > src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 4cbe52a > src/main/java/org/apache/hadoop/hbase/master/ServerManager.java a197b8f > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > b5ff43a > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 12a3cd8 > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java 7c1184c > > src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java > PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/replication/package.html PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java > PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java > PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java > PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java ed8709f > > src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java > PRE-CREATION > > Diff: http://review.hbase.org/r/76/diff > > > Testing > ------- > > > Thanks, > > Jean-Daniel > >
