----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/98/#review93 -----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/client/HConnection.java <http://review.hbase.org/r/98/#comment531> Properly document this argument. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.hbase.org/r/98/#comment534> Please use a concurrent collection and remove the synchronized blocks. For guidance, see around slide 30 of this presentation: http://www.cs.umd.edu/class/fall2009/cmsc132H/slides/still-effective.pdf src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.hbase.org/r/98/#comment532> Coding style: put the catch on the previous line. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.hbase.org/r/98/#comment533> We don't typically call methods using `this.methodname(args)' – remove the `this.' src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.hbase.org/r/98/#comment535> Add a space before the `:'. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.hbase.org/r/98/#comment536> Use `Boolean.TRUE' instead of `new Boolean(true)'. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.hbase.org/r/98/#comment537> Use `Boolean.FALSE' instead of `new Boolean(false)'. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.hbase.org/r/98/#comment538> Use `Boolean.TRUE' instead of `new Boolean(true)'. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.hbase.org/r/98/#comment539> Remove the outer parentheses. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.hbase.org/r/98/#comment540> Add a space before the `:'. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.hbase.org/r/98/#comment541> If this fits on the previous line while staying under 80 columns, please wrap it around. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.hbase.org/r/98/#comment542> Remove the space after `cacheLocation' src/main/java/org/apache/hadoop/hbase/client/HTable.java <http://review.hbase.org/r/98/#comment546> Use {...@link #readFields readFields} instead of <code>readFields</code> src/main/java/org/apache/hadoop/hbase/client/HTable.java <http://review.hbase.org/r/98/#comment544> You can remove this <p> src/main/java/org/apache/hadoop/hbase/client/HTable.java <http://review.hbase.org/r/98/#comment543> Use <pre> not <code> src/main/java/org/apache/hadoop/hbase/client/HTable.java <http://review.hbase.org/r/98/#comment545> Add a space before the `:'. src/main/java/org/apache/hadoop/hbase/client/HTable.java <http://review.hbase.org/r/98/#comment547> Use {...@link #getRegionsInfo getRegionsInfo} src/main/java/org/apache/hadoop/hbase/client/HTable.java <http://review.hbase.org/r/98/#comment548> Use {...@link ...} here and below. src/main/java/org/apache/hadoop/hbase/client/HTable.java <http://review.hbase.org/r/98/#comment550> Wrap this around with the previous line. src/main/java/org/apache/hadoop/hbase/client/HTable.java <http://review.hbase.org/r/98/#comment549> I believe you can remove this block. - Benoit On 2010-05-28 13:20:33, Mingjie Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/98/ > ----------------------------------------------------------- > > (Updated 2010-05-28 13:20:33) > > > Review request for hbase. > > > Summary > ------- > > HBASE-2468: Improvements to prewarm META cache on clients. > > Changes: > 1. Add new HTable methods which support region info de/serialation, and > region cache prewarm: > - void serializeRegionInfo(): clients could perform a large scan for all the > meta for the table, serialize the meta to a file. MR job can ship a copy of > the meta for the table in the DistributedCache > - Map<HRegionInfo, HServerAddress> deserializeRegionInfo(): MR job can > deserialize the region info from the DistributedCache > - prewarmRegionCache(Map<HRegionInfo, HServerAddress> regionMap): MR job can > prewarm local region cache by the deserialized region info. > > 2. For each client, each region cache read-miss could trigger read-ahead some > number of rows in META. This option could be turned on and off for one > particular table. > > > This addresses bug HBASE-2468. > http://issues.apache.org/jira/browse/HBASE-2468 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/client/HConnection.java 853164d > src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > 09de2ac > src/main/java/org/apache/hadoop/hbase/client/HTable.java 7ec95cb > src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 3de661e > src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java > 95e494a > > Diff: http://review.hbase.org/r/98/diff > > > Testing > ------- > > Unit tests passed locally for me. > > > Thanks, > > Mingjie > >
