-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/296/
-----------------------------------------------------------
(Updated 2010-07-13 16:32:18.729301)
Review request for hbase.
Changes
-------
Added changes to code after HBASE-2265 was committed.
Also, incorporated suggestion from Nicolas to not lookup when
columns.size*error.rate > 10%.
Changed BloomFilter interface, adding getErrorRate(). ByteBloomFilter now also
has errorRate stored.
Summary
-------
HBASE-2794 Enable bloom filter checks for multiple columns in same column family
This addresses bug HBASE-2794.
http://issues.apache.org/jira/browse/HBASE-2794
Diffs (updated)
-----
/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
963862
/trunk/src/main/java/org/apache/hadoop/hbase/util/BloomFilter.java 963873
/trunk/src/main/java/org/apache/hadoop/hbase/util/ByteBloomFilter.java 963873
/trunk/src/main/java/org/apache/hadoop/hbase/util/DynamicByteBloomFilter.java
963873
/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
963873
Diff: http://review.hbase.org/r/296/diff
Testing
-------
Ran and passed org.apache.hadoop.hbase.regionserver.TestStoreFile multiple
times. Ran and passed all tests when building.
Thanks,
Kris
