Can we display region server(s) which has this issue in a different color in Region Servers table on master.jsp ? Or better, can we add a column showing brief error message in Region Servers table ?
On Wed, Aug 25, 2010 at 11:57 AM, Jean-Daniel Cryans <[email protected]>wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/719/ > ----------------------------------------------------------- > > Review request for hbase. > > > Summary > ------- > > Trying to make some progress on this issue, here's an untested patch that > adds testing of codecs when the region server starts, then uses that to > check the schema of regions it tries to open. That's basically what this > jira's scope is about. > > Some things I don't like the way I did it: > - For all the users that don't do LZO, they will have a WARN every time a > RS starts (in its log) > - Does not cover cases where the files are LZOed, but the schema is NONE > or GZ > > Finally, there's no way to let user know about the errors unless he checks > the logs, but a least we won't throw ugly exceptions. > > > This addresses bug HBASE-2514. > http://issues.apache.org/jira/browse/HBASE-2514 > > > Diffs > ----- > > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 989204 > /trunk/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java > 989204 > > Diff: http://review.cloudera.org/r/719/diff > > > Testing > ------- > > > Thanks, > > Jean-Daniel > >
