On Wed, Sep 8, 2010 at 7:33 AM, Guilherme Germoglio <[email protected]> wrote: > However, I don't think it will cause any harm because the overwritten queue > will eventually be garbage-collected. :-) > > Should I write a patch for it? >
I agree its harmless looking but if you have a moment, please write a patch. > If so, I considered two approaches: > > 1. sync the *tables* attribute from lines 3 to 7. > 2. or consider the interface ConcurrentMap so we could use putIfAbsent() > > I prefer the second. What do you think? > Yes. Me too. Change tables to be a concurrent Map type instead of the wrap to make it synchronized. Thanks G, St.Ack
