----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/845/#review1204 -----------------------------------------------------------
Ship it! Looks like a fine refactor, but how does this change performance? src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java <http://review.cloudera.org/r/845/#comment4115> do we need these anymore? src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java <http://review.cloudera.org/r/845/#comment4114> can you just call through to initMethods() here? src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.cloudera.org/r/845/#comment4112> random junk - Todd On 2010-09-14 15:41:53, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/845/ > ----------------------------------------------------------- > > (Updated 2010-09-14 15:41:53) > > > Review request for hbase. > > > Summary > ------- > > HBASE-2997 performance improvements > > > This addresses bug HBASE-2997. > http://issues.apache.org/jira/browse/HBASE-2997 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 134288b > src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 92468e3 > src/main/java/org/apache/hadoop/hbase/master/HMaster.java bc21a1e > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > bba7b67 > > Diff: http://review.cloudera.org/r/845/diff > > > Testing > ------- > > > Thanks, > > Ryan > >
