----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/846/#review1217 -----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java <http://review.cloudera.org/r/846/#comment4131> this seems to be some kind of coordinate hand off so that the reader gets notified immediately of new things to read. this is mostly a straightforward port of the hadoop bug so i cant answer to the suitability of the design really... but it does work... reliably. src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java <http://review.cloudera.org/r/846/#comment4129> Not really sure, i dont think it should be possible, since this thread will only have 'accept' bits set on the sockets... but this is just a straightforward port of the HADOOP bug. src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java <http://review.cloudera.org/r/846/#comment4130> they used to accept up to 10 connections, then read from 1, then go back into the select loop. now the listener thread only accepts 1, then passes that to another thread to do the reads, so it doesnt have to attempt to keep socket accept() delays down by accepting batches at a time. - Ryan On 2010-09-14 15:43:46, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/846/ > ----------------------------------------------------------- > > (Updated 2010-09-14 15:43:46) > > > Review request for hbase. > > > Summary > ------- > > HBASE-2941 reader threads for hbase rpc > > > This addresses bug HBASE-2941. > http://issues.apache.org/jira/browse/HBASE-2941 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java d3c6c21 > > Diff: http://review.cloudera.org/r/846/diff > > > Testing > ------- > > > Thanks, > > Ryan > >
