----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/876/#review1380 -----------------------------------------------------------
Sorry for all the whitespace comments :) There are a bunch more in the test classes. src/main/java/org/apache/hadoop/hbase/HServerInfo.java <http://review.cloudera.org/r/876/#comment4581> The ternary operator does not need braces. src/main/java/org/apache/hadoop/hbase/client/Action.java <http://review.cloudera.org/r/876/#comment4582> The ternary operator does not need braces. src/main/java/org/apache/hadoop/hbase/client/Batch.java <http://review.cloudera.org/r/876/#comment4583> Remove extra character(s) src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/876/#comment4586> Should be of Type List<R> not ArrayList<R> src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/876/#comment4585> Why is this necessary? You already set the size by using the correct constructor. src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java <http://review.cloudera.org/r/876/#comment4588> Remove the "public", interfaces don't need that. src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java <http://review.cloudera.org/r/876/#comment4589> Remove the "public", interfaces don't need that. Also byte[] key in Map so every implementor has to make sure to use a Map that does this correctly. src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java <http://review.cloudera.org/r/876/#comment4590> Remove the "public", interfaces don't need that. src/main/java/org/apache/hadoop/hbase/coprocessor/BaseCommandTarget.java <http://review.cloudera.org/r/876/#comment4591> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/BaseCommandTarget.java <http://review.cloudera.org/r/876/#comment4592> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/BaseCommandTarget.java <http://review.cloudera.org/r/876/#comment4593> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java <http://review.cloudera.org/r/876/#comment4594> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java <http://review.cloudera.org/r/876/#comment4595> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java <http://review.cloudera.org/r/876/#comment4596> Inconsistent formatting src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java <http://review.cloudera.org/r/876/#comment4597> Inconsistent formatting src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java <http://review.cloudera.org/r/876/#comment4598> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java <http://review.cloudera.org/r/876/#comment4599> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java <http://review.cloudera.org/r/876/#comment4600> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java <http://review.cloudera.org/r/876/#comment4601> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java <http://review.cloudera.org/r/876/#comment4602> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java <http://review.cloudera.org/r/876/#comment4603> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java <http://review.cloudera.org/r/876/#comment4604> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java <http://review.cloudera.org/r/876/#comment4605> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4612> Remove public static final src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4606> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4613> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4614> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4615> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4607> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4616> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4617> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4608> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4618> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4609> Whitespace stuff Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4610> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4619> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4611> Whitespace stuff Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4620> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java <http://review.cloudera.org/r/876/#comment4621> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java <http://review.cloudera.org/r/876/#comment4622> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java <http://review.cloudera.org/r/876/#comment4623> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java <http://review.cloudera.org/r/876/#comment4624> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java <http://review.cloudera.org/r/876/#comment4625> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java <http://review.cloudera.org/r/876/#comment4626> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java <http://review.cloudera.org/r/876/#comment4627> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java <http://review.cloudera.org/r/876/#comment4628> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java <http://review.cloudera.org/r/876/#comment4629> Remove public src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorException.java <http://review.cloudera.org/r/876/#comment4630> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorException.java <http://review.cloudera.org/r/876/#comment4631> Remove extra space behind the brace src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4642> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4632> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4643> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4644> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4645> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4633> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4646> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4634> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4647> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4648> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4649> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4635> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4650> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4651> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4636> Whitespace stuff Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4637> Whitespace stuff Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4638> Whitespace stuff Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4639> Whitespace stuff Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4652> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4653> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4654> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4655> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4656> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4640> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4657> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4658> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4641> Whitespace stuff src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java <http://review.cloudera.org/r/876/#comment4659> Remove "public" src/main/java/org/apache/hadoop/hbase/coprocessor/package-info.java <http://review.cloudera.org/r/876/#comment4707> Lots of whitespace stuff in this file. I've not listed them all. src/main/java/org/apache/hadoop/hbase/ipc/ConnectionHeader.java <http://review.cloudera.org/r/876/#comment4708> public Log? src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java <http://review.cloudera.org/r/876/#comment4709> private static final src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java <http://review.cloudera.org/r/876/#comment4710> Whitespace stuff src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java <http://review.cloudera.org/r/876/#comment4711> Whitespace stuff src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java <http://review.cloudera.org/r/876/#comment4712> Whitespace stuff src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java <http://review.cloudera.org/r/876/#comment4713> Whitespace stuff src/main/java/org/apache/hadoop/hbase/ipc/SecureClient.java <http://review.cloudera.org/r/876/#comment4714> Wrong formatting src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java <http://review.cloudera.org/r/876/#comment4715> Whitespace stuff src/main/java/org/apache/hadoop/hbase/ipc/Status.java <http://review.cloudera.org/r/876/#comment4716> Whitespace stuff src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java <http://review.cloudera.org/r/876/#comment4717> Whitespace stuff src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java <http://review.cloudera.org/r/876/#comment4718> Whitespace stuff src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java <http://review.cloudera.org/r/876/#comment4719> Whitespace stuff src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java <http://review.cloudera.org/r/876/#comment4720> Whitespace stuff src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java <http://review.cloudera.org/r/876/#comment4721> Whitespace stuff src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java <http://review.cloudera.org/r/876/#comment4722> Whitespace stuff src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java <http://review.cloudera.org/r/876/#comment4723> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4724> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4725> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4726> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4727> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4728> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4729> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4730> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4731> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4732> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4733> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4734> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4735> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4736> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4739> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4737> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4740> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4741> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4742> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4743> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4745> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4744> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4746> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4747> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4748> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4749> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4750> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4751> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4752> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4753> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4754> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4755> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4756> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4757> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4758> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4759> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4761> Inconsistent indentation with most of the rest of the file src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4760> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4762> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4763> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4764> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4765> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4766> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4768> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4767> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4770> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4771> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4773> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4772> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4774> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4775> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4776> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4777> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4778> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4779> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4780> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4781> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/876/#comment4782> Lock should be acquired before the try block src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.cloudera.org/r/876/#comment4783> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.cloudera.org/r/876/#comment4784> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.cloudera.org/r/876/#comment4785> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.cloudera.org/r/876/#comment4786> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.cloudera.org/r/876/#comment4787> Whitespace stuff and no comment for this parameter src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.cloudera.org/r/876/#comment4788> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.cloudera.org/r/876/#comment4789> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.cloudera.org/r/876/#comment4790> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.cloudera.org/r/876/#comment4791> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java <http://review.cloudera.org/r/876/#comment4792> Whitespace stuff src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.cloudera.org/r/876/#comment4793> src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java <http://review.cloudera.org/r/876/#comment4794> Whitespace stuff src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java <http://review.cloudera.org/r/876/#comment4795> Whitespace stuff src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java <http://review.cloudera.org/r/876/#comment4796> Whitespace stuff src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java <http://review.cloudera.org/r/876/#comment4797> Whitespace stuff src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java <http://review.cloudera.org/r/876/#comment4798> Whitespace stuff src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java <http://review.cloudera.org/r/876/#comment4799> Whitespace stuff src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java <http://review.cloudera.org/r/876/#comment4800> Whitespace stuff src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java <http://review.cloudera.org/r/876/#comment4801> Whitespace stuff src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java <http://review.cloudera.org/r/876/#comment4802> Whitespace stuff src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java <http://review.cloudera.org/r/876/#comment4803> Whitespace stuff src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java <http://review.cloudera.org/r/876/#comment4805> Unnecessary, comments are automatically inherited src/main/resources/hbase-default.xml <http://review.cloudera.org/r/876/#comment4806> Whitespace stuff src/main/resources/hbase-default.xml <http://review.cloudera.org/r/876/#comment4807> Whitespace stuff src/main/resources/hbase-default.xml <http://review.cloudera.org/r/876/#comment4808> Whitespace stuff src/main/resources/hbase-default.xml <http://review.cloudera.org/r/876/#comment4810> Whitespace stuff src/main/resources/hbase-default.xml <http://review.cloudera.org/r/876/#comment4811> Whitespace stuff - Lars On 2010-10-02 23:53:05, Mingjie Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/876/ > ----------------------------------------------------------- > > (Updated 2010-10-02 23:53:05) > > > Review request for hbase, stack, Andrew Purtell, and Jonathan Gray. > > > Summary > ------- > > The diff actually contains 2 seperate patches: HBase-2001 and the one for > (HBASE-2002+HBASE-2321). The reason is that HBase-2001's CommandTarget relies > on HBASE-2002 + HBASE-2321 which patches are still under review. I have to > include Gary's HBASE-2002, HBASE-2321 with this diff, since reviewboard is so > powerful :) and it disallow my diff to be based on some unchecked in patch. > > Eventually the patch here should be committed after 2001 and 2321. I will > make another patch after they got checked in. > > Both HBase-2001 and the dynamic RPC stuff are quite big patches. Total number > of lines are more than 7k. I turned back and forth, but still don't have a > good idea to create the patch in order to reduce the review pain. However > right now I'm putting the whole patch for all the 3 issues. Here the list of > file which are only related to coprocessor: > > src/main/java/org/apache/hadoop/hbase/coprocessor/BaseCommandTarget.java > src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java > src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java > src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java > src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorException.java > src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java > src/main/java/org/apache/hadoop/hbase/coprocessor/package-info.java > src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java > src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java > src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java > src/main/resources/hbase-default.xml > src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassloading.java > src/test/java/org/apache/hadoop/hbase/coprocessor/TestCommandTarget.java > src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java > src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java > src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java > > > ========================== > > (Here is a brief description. Please find much more details at the > package-info.java in the diff. I also post the package-info.html to > https://issues.apache.org/jira/browse/HBASE-2001 as an attachment.) > > > Coprocessors are code that runs in-process on each region server. Regions > contain references to the coprocessor implementation classes associated with > them. Coprocessor classes will be loaded either from local jars on the region > server's classpath or via the HDFS classloader. > > Multiple types of coprocessors are provided to provide sufficient flexibility > for potential use cases. Right now there are: > > * Coprocessor: provides region lifecycle management hooks, e.g., region > open/close/split/flush/compact operations. > * RegionObserver: provides hook for monitor table operations from client > side, such as table get/put/scan/delete, etc. > * CommandTarget: provides on demand triggers for any arbitrary function > executed at a region. One use case is column aggregation at region server. > > Coprocessor: > A coprocessor is required to implement Coprocessor interface so that > coprocessor framework can manage it internally. > > Another design goal of this interface is to provide simple features for > making coprocessors useful, while exposing no more internal state or control > actions of the region server than necessary and not exposing them directly. > > RegionObserver > If the coprocessor implements the RegionObserver interface it can observe and > mediate client actions on the region. > > CommandTarget: > Coprocessor and RegionObserver provide certain hooks for injecting user code > running at each region. These code will be triggerd with existing HTable and > HBaseAdmin operations at the certain hook points. > > Through CommandTarget and dynamic RPC protocol, you can define your own > interface communicated between client and region server, i.e., you can > specify new passed parameters and return types for a method. And the new > CommandTarget methods can be triggered by calling client side dynamic RPC > functions -- HTable.exec(...). > > Coprocess loading > A customized coprocessor can be loaded by two different ways, by > configuration, or by HTableDescriptor for a newly created table. > > (Currently we don't really have an on demand coprocessor loading machanism > for opened regions. However it should be easy to create a dedicated > CommandTarget for coprocessor loading) > > > This addresses bug HBase-2001. > http://issues.apache.org/jira/browse/HBase-2001 > > > Diffs > ----- > > conf/hbase-policy.xml PRE-CREATION > src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java 365e4b9 > src/main/java/org/apache/hadoop/hbase/HServerAddress.java 3859968 > src/main/java/org/apache/hadoop/hbase/HServerInfo.java aaf4835 > src/main/java/org/apache/hadoop/hbase/client/Action.java 556ea81 > src/main/java/org/apache/hadoop/hbase/client/Batch.java PRE-CREATION > src/main/java/org/apache/hadoop/hbase/client/Exec.java PRE-CREATION > src/main/java/org/apache/hadoop/hbase/client/ExecResult.java PRE-CREATION > src/main/java/org/apache/hadoop/hbase/client/HConnection.java 65f7618 > src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > 0feb17c > src/main/java/org/apache/hadoop/hbase/client/HTable.java 0dbf263 > src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java 74593bf > src/main/java/org/apache/hadoop/hbase/client/MultiAction.java c6ea838 > src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java 91bd04b > src/main/java/org/apache/hadoop/hbase/client/RowRange.java PRE-CREATION > src/main/java/org/apache/hadoop/hbase/client/Scan.java 29b3cb0 > src/main/java/org/apache/hadoop/hbase/coprocessor/BaseCommandTarget.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java > PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorException.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/coprocessor/package-info.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 83f623d > src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java 3a429c0 > src/main/java/org/apache/hadoop/hbase/ipc/ConnectionHeader.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java PRE-CREATION > src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 2b5eeb6 > src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java e23a629 > src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 19dbf2b > src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java e4c356d > src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java bacf8b1 > src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java > 71a0447 > src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java ee5dd8f > src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java PRE-CREATION > src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java PRE-CREATION > src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java PRE-CREATION > src/main/java/org/apache/hadoop/hbase/ipc/SecureClient.java PRE-CREATION > src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java PRE-CREATION > src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java PRE-CREATION > src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION > src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/master/HMaster.java fb1e834 > src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 0a4fbce > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 89f499a > > src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java > 4ba63d8 > src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java > 9aaf7c3 > > src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java > 01475d5 > src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java d4166cf > src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java > PRE-CREATION > src/main/resources/hbase-default.xml 5fafe65 > src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java e5b1a30 > src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 63a6956 > src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassloading.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/coprocessor/TestCommandTarget.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java 377e6b1 > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java > dc55407 > > Diff: http://review.cloudera.org/r/876/diff > > > Testing > ------- > > > Thanks, > > Mingjie > >
