----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1130/#review1719 -----------------------------------------------------------
Ship it! +1 for now. I think yeah that we are going to have to do a sweep of these handlers and the Meta* classes and make them all do the same exception handling catching the same types but letting out (and aborting) for others -- but lets get a bit more experience first. - stack On 2010-10-29 15:52:55, Jonathan Gray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1130/ > ----------------------------------------------------------- > > (Updated 2010-10-29 15:52:55) > > > Review request for hbase and stack. > > > Summary > ------- > > Unwraps RemoteExceptions and we don't abort if it's an NSRE. > > This handling is rather different from the handling of opens (we abort in > some cases here), so we might consider making them the same and no longer > aborting here. I'm fine with leaving it for a while longer as we do all this > testing. > > > This addresses bug HBASE-3163. > http://issues.apache.org/jira/browse/HBASE-3163 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > 1028936 > > Diff: http://review.cloudera.org/r/1130/diff > > > Testing > ------- > > > Thanks, > > Jonathan > >
