----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1136/#review1727 -----------------------------------------------------------
Ship it! Looks good Andy. Theres a bit of white space. Try squash it on commit. You don't have a test of the new facility. Would that be hard to add? - stack On 2010-10-30 01:29:22, Andrew Purtell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1136/ > ----------------------------------------------------------- > > (Updated 2010-10-30 01:29:22) > > > Review request for hbase. > > > Summary > ------- > > Introduce a table schema attribute for column families that instructs the > REST gateway to perform input and/or output transcoding, with base64->binary > (for GET) and vice versa (for PUT or POST) as the first supported option. > > > This addresses bug HBASE-3120. > http://issues.apache.org/jira/browse/HBASE-3120 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/rest/ExistsResource.java d83dc20 > src/main/java/org/apache/hadoop/hbase/rest/RegionsResource.java 54f2dc7 > src/main/java/org/apache/hadoop/hbase/rest/RowResource.java 1bf17b8 > src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java 5bb90ef > src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java 7262229 > src/main/java/org/apache/hadoop/hbase/rest/TableResource.java 5f305db > src/main/java/org/apache/hadoop/hbase/rest/transform/Base64.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/rest/transform/NullTransform.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/rest/transform/Transform.java > PRE-CREATION > > Diff: http://review.cloudera.org/r/1136/diff > > > Testing > ------- > > Created a test table. Modified the HCD of a column family by adding a custom > attribute of 'Transform$1' => '*:Base64'. Used curl to store the string > "Testing 1, 2, 3" using content type application/octet-stream. Confirmed with > shell the value was base64 encoded in table. Used curl to retrieve the value > using accept header of application/octet-stream and confirmed the response > body was the decoded string. > > > Thanks, > > Andrew > >
