----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1295/#review2063 -----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserverCoprocessor.java <http://review.cloudera.org/r/1295/#comment6478> presumably a co-processor could modify the Get object to implement policy? Another consideration is replacing the Get query with an alternate query, for example we have InternalGet subclasses for additional functionality, I'm just winging this though. src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java <http://review.cloudera.org/r/1295/#comment6479> unless you need CAS semantics, you can just use volatile here. We are over-using the Atomic* stuff sometimes. - Ryan On 2010-12-14 18:16:21, Andrew Purtell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1295/ > ----------------------------------------------------------- > > (Updated 2010-12-14 18:16:21) > > > Review request for hbase, Jonathan Gray and Mingjie Lai. > > > Summary > ------- > > Currently an observer can act as a filter or translator but cannot stop a > subsequent call down to the base method for get, put, delete, etc. This patch > allows observers to 1) keep any subsequently chained observer from executing, > or 2) prevent default behavior from executing. This latter option allows a > preXXX hook to completely reimplement something. > > I also found and fixed some logic bugs in coprocessor framework integration > in HRegion. > > I will squelch the added extraneous whitespace upon commit. > > > This addresses bug HBASE-3348. > http://issues.apache.org/jira/browse/HBASE-3348 > > > Diffs > ----- > > > src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserverCoprocessor.java > 134ed2f > > src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java > 654b179 > src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java > 10dfff4 > src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java > c57ca0c > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java cf9cad0 > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 8248f5f > src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java > 345790f > > src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java > 9ef3562 > > Diff: http://review.cloudera.org/r/1295/diff > > > Testing > ------- > > All coprocessor unit tests pass. No failures of other unit tests observed > that might be related to these changes. > > > Thanks, > > Andrew > >
