TestHeapSize passed without the change below. However, TestHeapSize failed in TRUNK build.
I added an integer to FIXED_OVERHEAD. TestHeapSize passed on my laptop and on Linux. FYI On Thu, Jul 7, 2011 at 5:41 PM, Stack <[email protected]> wrote: > There is no change in this commit? > > > > On Jul 7, 2011, at 17:27, [email protected] wrote: > > > Author: tedyu > > Date: Fri Jul 8 00:27:36 2011 > > New Revision: 1144102 > > > > URL: http://svn.apache.org/viewvc?rev=1144102&view=rev > > Log: > > HBASE-3893 account for new int field for FIXED_OVERHEAD > > > > Modified: > > > hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > > > > Modified: > hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > > URL: > http://svn.apache.org/viewvc/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java?rev=1144102&r1=1144101&r2=1144102&view=diff > > > ============================================================================== > > --- > hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > (original) > > +++ > hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Fri Jul 8 00:27:36 2011 > > @@ -3613,7 +3613,7 @@ public class HRegion implements HeapSize > > public static final long FIXED_OVERHEAD = ClassSize.align( > > ClassSize.OBJECT + > > ClassSize.ARRAY + > > - 27 * ClassSize.REFERENCE + > > + 27 * ClassSize.REFERENCE + Bytes.SIZEOF_INT + > > (4 * Bytes.SIZEOF_LONG) + > > Bytes.SIZEOF_BOOLEAN); > > > > > > >
