Review finished. Looks great! Just a few minor touch-ups I mentioned on RB.
On Wed, Jul 27, 2011 at 1:24 PM, Stack <st...@duboce.net> wrote: > Will apply after Todd finishes his review. > St.Ack > > > On Wed, Jul 27, 2011 at 1:19 PM, Andrew Purtell <apurt...@apache.org> > wrote: > > This vote has carried. > > > > Best regards, > > > > > > - Andy > > > > Problems worthy of attack prove their worth by hitting back. - Piet Hein > (via Tom White) > > > > > >>________________________________ > >>From: Jean-Daniel Cryans <jdcry...@apache.org> > >>To: dev@hbase.apache.org > >>Sent: Wednesday, July 27, 2011 11:36 AM > >>Subject: Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94? > >> > >>+1 > >> > >>On Tue, Jul 26, 2011 at 7:17 PM, Stack <st...@duboce.net> wrote: > >>> Shall we commit the patch at > >>> https://issues.apache.org/jira/browse/HBASE-3857 for 0.92? > >>> > >>> I reviewed it and its high-quality, with lots of new tests, and an > >>> attention to self-migration (which it does) that is heartening. > >>> > >>> I'm +1 on committing it now to TRUNK in time for 0.92 before this fat > >>> patch rots our on JIRA. > >>> > >>> What you lot think? > >>> > >>> St.Ack > >>> > >> > >> > >> > -- Todd Lipcon Software Engineer, Cloudera
