If it's completely a coprocessor, then it seems we should let it bake on github and only incorporate in core if we find that a number of the core HBase users are using it in production. Am I misunderstanding the implementation? (haven't looked at the most recent patch)
-Todd On Mon, Dec 12, 2011 at 3:50 PM, <yuzhih...@gmail.com> wrote: > Waiting for review comments from other committers. > The implementation is pluggable by using coprocessors. > > Cheers > > > > On Dec 12, 2011, at 5:43 PM, Stack <st...@duboce.net> wrote: > >> On Mon, Dec 12, 2011 at 6:43 AM, <yuzhih...@gmail.com> wrote: >>> Hi, >>> 4120 has gone through more than 20 revisions. >>> >>> Please provide your comments. >>> >>> I plan to integrate it this week. >>> >> >> I'd suggest hold on commit until some other committers have had a >> looksee. This is an important feature that we need to get right and >> there is no need to rush it in. >> >> Thanks Ted (and thanks for the reviews so far), >> St.Ack -- Todd Lipcon Software Engineer, Cloudera