I agree we should get findbugs down to zero. In the interim, what I did for HBASE-7329 was to diff a known good newPatchFindbugsWarningshbase-server.xml with the one generated by Hadoop QA and look for warnings on the classes touched by the patch.
Cheers On Thu, Jan 17, 2013 at 5:16 PM, Enis Söztutar <[email protected]> wrote: > Yes, I was also surprised some time ago, that our findbugs reports does not > show the diff, but the whole, and you need dark skills to find those the > patch has caused. > > The only reasonable way to proceed is to get them to zero. > > > On Thu, Jan 17, 2013 at 10:41 AM, Sergey Shelukhin > <[email protected]>wrote: > > > One issue with the current situation is that it's pretty hard to > > understand what warnings are new, and in some JIRAs the report seems > > to be wrong (e.g. if you download the reports from old and new build > > you see the difference is only in dates and timing). > > I filed a JIRA to make it better (so you could rely on it and see what > > to fix) but I won't be able to get around to it at least until next > > week :( > > > > On Wed, Jan 16, 2013 at 12:16 PM, Stack <[email protected]> wrote: > > > On Wed, Jan 16, 2013 at 10:57 AM, Nicolas Liochon <[email protected]> > > wrote: > > > > > >> I think the only simple solution is to put it to zero, then it's easy > to > > >> see what's new. But it requires some work. Not much. But some :-( > > >> > > >> > > > Figured. You are right N. Thanks. Lets squash this last set... > > > St.Ack > > >
