That is correct. On Thu, Mar 14, 2013 at 9:28 AM, ramkrishna vasudevan < ramkrishna.s.vasude...@gmail.com> wrote:
> So seeing the final patch it means that whatever Liang has asked for is not > available right? > > Regards > Ram > > On Thu, Mar 14, 2013 at 9:55 PM, Ted Yu <yuzhih...@gmail.com> wrote: > > > The issue was HBASE-7902 > > > > The final patch was just mostly renaming: > > > > - Collections.singletonList(memstoreScanner), > > ScanType.MINOR_COMPACT, > > + Collections.singletonList(memstoreScanner), > > ScanType.COMPACT_RETAIN_DELETES, > > > > Cheers > > > > On Thu, Mar 14, 2013 at 9:22 AM, Anoop John <anoop.hb...@gmail.com> > wrote: > > > > > Hi > > > I have seen some issue raised by Sergey regarding removing > > Delete > > > markers during minor compaction. Not remembering the issue id and > details > > > :( > > > > > > -Anoop- > > > > > > > > > On Thu, Mar 14, 2013 at 3:11 PM, 谢良 <xieli...@xiaomi.com> wrote: > > > > > > > Currently, all tombstones only get cleaned up with major > compactions. I > > > > guess the original > > > > design probably considered that we need to ensure whether there are > > other > > > > versions of > > > > the deleted key in other storefiles which are not included in minor > > > > compaction? If that's > > > > true, i have a thought, maybe we could delete a bunch of tombstones > per > > > > bloom filter, in > > > > other words, we can try to query the deleted key in other > storefiles's > > > > bloom filter info to determine > > > > whether we can remove it safely or not. > > > > I am not familiar with compaction&bloomfilter internal, it's just a > raw > > > > thought right now:) > > > > > > > > Regards, > > > > Liang > > > > > >
