By lockRow did you mean this (in HRegion.java): + @VisibleForTesting void getRowLock(byte[] row) throws IOException {
Cheers On Sat, Jul 6, 2013 at 10:04 PM, Anoop John <anoop.hb...@gmail.com> wrote: > +1 from me for changing the CP signature by removing lockids.. CP will be > able to acquire lock on rows? (lockRow will be still public?) > > -Anoop- > > On Sun, Jul 7, 2013 at 3:34 AM, Ted Yu <yuzhih...@gmail.com> wrote: > > > +1 on the removal of lock Ids. > > > > On Sat, Jul 6, 2013 at 2:49 PM, Dave Latham <lat...@davelink.net> wrote: > > > > > In HBASE-8877 I'm proposing to change row locks to be reentrant and > > thread > > > based rather than tracking lock ids. Part of that change would mean > > > altering the RegionObserver coprocessor. Specifically, the methods > > > preBatchMutate and postBatchMutate would have the parameter > > > MiniBatchOperationInProgress<Pair<Mutation, > > > Integer>> miniBatchOp become > > > MiniBatchOperationInProgress<Mutation> miniBatchOp > > > > > > Does anyone rely on lock ids for this coprocessor or object to the > > change? > > > Is it safe to make this incompatible change for 0.96? > > > > > > Thanks, Andrew, for already chiming in on the issue. > > > For more background, see that issue and discussion on HBASE-8806. > > > > > > Dave > > > > > >