I took a look. While the patch is trivial enough, I think we should do something do something more drastic. We should deprecate/remove Reusable and Threadlocal PoolMaps for the rpc clients. Reusable PoolMap in conjunction with the code becomes resource unbounded and ThreadLocal is tricky to use (difficult to close or interrupt since we have to hunt down all the threads).
For now we should deprecate the other two and once 1.0 gets branched we should remove Reusable and Threadlocal and possibly just get rid of the extra config infrastructure. Jon. On Tue, Jun 10, 2014 at 5:27 PM, Jean-Marc Spaggiari < [email protected]> wrote: > Hi Konstantin, I'm talking about this one: > https://issues.apache.org/jira/browse/HBASE-11313 > > Thanks, > > JM > > > 2014-06-10 20:14 GMT-04:00 Konstantin Boudnik <[email protected]>: > > > Seems to be a private one? Unless I am not in the correct group or > > something... > > > > On Tue, Jun 10, 2014 at 07:58PM, Jean-Marc Spaggiari wrote: > > > Pretty trivial patch. > > > > > > Thanks, > > > > > > JM > > > -- // Jonathan Hsieh (shay) // HBase Tech Lead, Software Engineer, Cloudera // [email protected] // @jmhsieh
