On Wed, Aug 20, 2014 at 12:21 PM, Jean-Marc Spaggiari <
jean-m...@spaggiari.org> wrote:

> Ok. So -Dhadoop.two.version and -Dhadoop.version are exclusives, right?
> Even if it's not enforced, it's not logic to have the 2 together.
>

Some of this stuff is historical. This pom has evolved from the same one
that drove previous releases, where more gymnastics were required to build
more combinations of hbase and hadoop. Since we've dropped hadoop-1
support, could be things can be simplified a bit.

2014-08-20 15:12 GMT-04:00 Ted Yu <yuzhih...@gmail.com>:
>
> > Minor correction: -Dhadoop-two.version=2.3.0 should be used.
> >
> > Cheers
> >
> >
> > On Wed, Aug 20, 2014 at 12:07 PM, Nick Dimiduk <ndimi...@gmail.com>
> wrote:
> >
> > > The hadoop related profiles are for major versions (in branch-1 and
> > > master). We have "hadoop-2.0" (current default) and "hadoop-3.0"
> (enabled
> > > by specifying -Dhadoop.profile=3.0). I don't know why profiles are
> > enabled
> > > via property instead of by specifying the property (-P). These profiles
> > > specify which hbase modules and dependency artifact (not version)
> should
> > be
> > > used.
> > >
> > > The exact hadoop version is specified by a separate property. The
> > > hadoop-2.0 profile check the property "hadoop-two.version". The
> > hadoop-3.0
> > > profile appears to use "hadoop.version" property.
> > >
> > > So to build branch-1 vs hadoop-2.3.0, you would use "mvn
> > > -Phadoop-two.version=2.3.0".
> > >
> > > At least, that's what it looks like by reading the pom. Any patches to
> > > clean these parts of the build are welcome ;)
> > >
> > > -n
> > >
> > >
> > > On Wed, Aug 20, 2014 at 11:55 AM, Jean-Marc Spaggiari <
> > > jean-m...@spaggiari.org> wrote:
> > >
> > > > " don't specify hadoop.profile unless != 2.0."
> > > >
> > > > So if we build against 2.3.0 should we specify -Phadoop.profile=2.3 ?
> > Or
> > > we
> > > > don't specify unless != 2.x?
> > > >
> > > > Thanks,
> > > >
> > > > JM
> > > >
> > > >
> > > > 2014-08-14 14:03 GMT-04:00 Esteban Gutierrez <este...@cloudera.com>:
> > > >
> > > > > What Andrew said. I'm building against 2.3.0 without any issue so
> > far.
> > > > >
> > > > > cheers,
> > > > > esteban.
> > > > >
> > > > >
> > > > > --
> > > > > Cloudera, Inc.
> > > > >
> > > > >
> > > > >
> > > > > On Thu, Aug 14, 2014 at 10:58 AM, Andrew Purtell <
> > apurt...@apache.org>
> > > > > wrote:
> > > > >
> > > > > > Oh. Sorry. Just remembered... to select the default profile you
> > don't
> > > > > > specify hadoop.profile. -Phadoop.profile=2.0 will cause issues,
> > yes,
> > > > > don't
> > > > > > specify hadoop.profile unless != 2.0. And IIRC specifying a
> > specific
> > > > > Hadoop
> > > > > > 2 version requires:
> > > > > >
> > > > > > -Dhadoop.version=2.x.x -Dhadoop-two.version=2.x.x
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Thu, Aug 14, 2014 at 10:51 AM, Vladimir Rodionov <
> > > > > > vladrodio...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > -Phadoop.version=2.2 worked fine to me. I was able to build
> > package
> > > > and
> > > > > > > create eclipse workspace. I just checked dependencies and all
> > > hadoop
> > > > > libs
> > > > > > > are 2.2?
> > > > > > >
> > > > > > > -Vladimir Rodionov
> > > > > > >
> > > > > > >
> > > > > > > On Thu, Aug 14, 2014 at 10:37 AM, Andrew Purtell <
> > > > apurt...@apache.org>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > There is no hadoop.profile named "2.2". Use "2.0"
> > > > > > > >
> > > > > > > >
> > > > > > > > On Thu, Aug 14, 2014 at 10:34 AM, Vladimir Rodionov <
> > > > > > > > vladrodio...@gmail.com>
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Actually, -Phadoop.profile=2.2.
> > > > > > > > >
> > > > > > > > > -Vladimir Rodionov
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Thu, Aug 14, 2014 at 10:28 AM, Jean-Marc Spaggiari <
> > > > > > > > > jean-m...@spaggiari.org> wrote:
> > > > > > > > >
> > > > > > > > > > You should try mvn clean package -DskipTests
> > > > -Dhadoop.profile=2.0
> > > > > > > > > >
> > > > > > > > > > JM
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > 2014-08-14 13:27 GMT-04:00 Vladimir Rodionov <
> > > > > > vladrodio...@gmail.com
> > > > > > > >:
> > > > > > > > > >
> > > > > > > > > > > I just synced my local 0.98-trunk and tried to build
> it:
> > > > > > > > > > >
> > > > > > > > > > > mvn clean package -DskipTests -Dhadoop.profile=2.2
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > [INFO] Scanning for projects...
> > > > > > > > > > > [ERROR] The build could not read 1 project -> [Help 1]
> > > > > > > > > > > [ERROR]
> > > > > > > > > > > [ERROR]   The project
> > > org.apache.hbase:hbase:0.98.6-SNAPSHOT
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> (/Users/vrodionov/Development/hbase/vanila/hbase-0.98-trunk-patch-new/pom.xml)
> > > > > > > > > > > has 2 errors
> > > > > > > > > > > [ERROR]
> > > > > > > 'dependencyManagement.dependencies.dependency.artifactId'
> > > > > > > > > for
> > > > > > > > > > > org.apache.hbase:${compat.module}:jar with value
> > > > > > '${compat.module}'
> > > > > > > > > does
> > > > > > > > > > > not match a valid id pattern. @ line 997, column 21
> > > > > > > > > > > [ERROR]
> > > > > > > 'dependencyManagement.dependencies.dependency.artifactId'
> > > > > > > > > for
> > > > > > > > > > > org.apache.hbase:${compat.module}:test-jar with value
> > > > > > > > > '${compat.module}'
> > > > > > > > > > > does not match a valid id pattern. @ line 1002, column
> 21
> > > > > > > > > > > [ERROR]
> > > > > > > > > > > [ERROR] To see the full stack trace of the errors,
> re-run
> > > > Maven
> > > > > > > with
> > > > > > > > > the
> > > > > > > > > > -e
> > > > > > > > > > > switch.
> > > > > > > > > > > [ERROR] Re-run Maven using the -X switch to enable full
> > > debug
> > > > > > > > logging.
> > > > > > > > > > > [ERROR]
> > > > > > > > > > > [ERROR] For more information about the errors and
> > possible
> > > > > > > solutions,
> > > > > > > > > > > please read the following articles:
> > > > > > > > > > > [ERROR] [Help 1]
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > -Vladimir Rodionov
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Best regards,
> > > > > > > >
> > > > > > > >    - Andy
> > > > > > > >
> > > > > > > > Problems worthy of attack prove their worth by hitting back.
> -
> > > Piet
> > > > > > Hein
> > > > > > > > (via Tom White)
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Best regards,
> > > > > >
> > > > > >    - Andy
> > > > > >
> > > > > > Problems worthy of attack prove their worth by hitting back. -
> Piet
> > > > Hein
> > > > > > (via Tom White)
> > > > > >
> > > > >
> > > >
> > >
> >
>

Reply via email to