OK, makes sense. Should be deprecated or even removed.
-Vlad
On Tue, Mar 17, 2015 at 10:54 AM, Andrew Purtell <apurt...@apache.org>
wrote:
> "git blame"?
>
> Says c32e7651, which is
>
> commit c32e76518f832566bd67c80588cd99d6ad315641
> Author: rahulgidwani <rahul.gidw...@flurry.com>
> Date: Mon Jan 26 18:44:25 2015 -0800
>
> HBASE-12627 Add back snapshot batching facility
>
> Signed-off-by: Andrew Purtell <apurt...@apache.org>
>
> How files are determined to be deletable changed. We could clean this up
> further, though, since isFileDeletable became vestigial, it should be
> deprecated or removed.
>
>
> On Tue, Mar 17, 2015 at 10:36 AM, Vladimir Rodionov <
> vladrodio...@gmail.com>
> wrote:
>
> > Literally?
> >
> > in master and current 0.98 it always says "file is not deletable"
> >
> > @Override
> >
> > protected boolean isFileDeletable(FileStatus fStat) {
> >
> > return false;
> >
> > }
> >
> >
> > This is from 0.98.6 (CDH 5.3.0)
> >
> > @Override
> >
> > public synchronized boolean isFileDeletable(FileStatus fStat) {
> >
> > try {
> >
> > return !cache.contains(fStat.getPath().getName());
> >
> > } catch (IOException e) {
> >
> > LOG.error("Exception while checking if:" + fStat.getPath()
> >
> > + " was valid, keeping it just in case.", e);
> >
> > return false;
> >
> > }
> >
> > }
> >
> >
> > Any thoughts, folks?
> >
> >
> > -Vlad
> >
>
>
>
> --
> Best regards,
>
> - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
>
