It's never too late Enis, well, until a vote passes anyway. :-) Thanks for looking in to the ramifications of this change.
An practically-infinite timeout is a bug by definition. I think we should have something like this change in 0.98.13 and the 1.x-es. Your point about the new 60 second default being too aggressive / surprising makes sense. Let's reapply to 0.98 and 1.x with a larger default. A code change is needed, so I will cancel this RC vote. A reasonable new default could be to take the zookeeper timeout and multiply it by 2. Or, we could go with another fixed, but larger value, like 5 or 10 minutes. What bothers me is INT_MAX, let's not have that. Regardless I think it would be good if we also file an issue to update the book with discussion on zookeeper and RPC timeouts and their relationship. > On May 30, 2015, at 5:34 AM, Enis Söztutar <e...@apache.org> wrote: > > Sorry to be late, but I would vote -0 because of: > > https://issues.apache.org/jira/browse/HBASE-13647?focusedCommentId=14565266&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14565266 > > I don't think it is acceptable to change the default so aggressively in > 0.98-1.1 releases. > > Enis > >> On Wed, May 27, 2015 at 2:54 PM, Andrew Purtell <apurt...@apache.org> wrote: >> >> The 1st HBase 0.98.13 release candidate (RC0) is available for >> download at http://people.apache.org/~apurtell/0.98.13RC0/ and Maven >> artifacts are also available in the temporary repository >> https://repository.apache.org/content/repositories/orgapachehbase-1082/ >> >> The API compatibility report with respect to the previous release can be >> found at >> http://people.apache.org/~apurtell/0.98.12_0.98.13RC0_compat_report.html . >> There are 0 reported binary or source compatibility issues. >> >> Signed with my code signing key D5365CCD. >> >> The issues resolved in this release can be found at >> http://s.apache.org/F70 >> . >> >> Please try out the candidate and vote +1/-1 by midnight Pacific Time (00:00 >> -0800 GMT) on June 3 on whether or not we should release this as >> 0.98.13. Three +1 votes from PMC will be required to release. >> >> >> -- >> >> >> Best regards, >> >> - Andy >> >> Problems worthy of attack prove their worth by hitting back. - Piet Hein >> (via Tom White) >>