There are 31 usages MiniMRCluster in unit tests, and i did't see any tests which test the locality feature for map task.
IMO we can remove them firstly, and see what QA says. How do you think about it? @stack @eclark 2015-10-23 3:40 GMT+08:00 Stack <[email protected]>: > On Wed, Oct 21, 2015 at 10:01 PM, 陈恒 <[email protected]> wrote: > > > When i dig in HBASE-14659, i found in testcase TestHFileOutputFormat, > > some tests run MR job > > without MiniMRCluster and some run with it. > > > > > > The ones with no MiniMRCluster run much faster! > > Do we need to 'test' clustered MR especially in a unit test? > > > > > > > We have some fat unit tests that spin up loads of mini clusters. For MR, > the same code base is exercised whether cluster or not so if no MR cluster > means less resources used by test and all runs faster, I'd be +1 in favor > of undoing cluster (for all but the cases where cluster needed to prove > some code as per example Elliott raises above). > > Thanks 陈恒 > St.Ack >
