Sorry, this is the one. https://issues.apache.org/jira/browse/HBASE-14917
On Wed, Dec 2, 2015 at 9:21 PM, Apekshit Sharma <a...@cloudera.com> wrote: > https://issues.apache.org/jira/browse/HBASE-14916 > > On Wed, Dec 2, 2015 at 7:52 PM, Ted Yu <yuzhih...@gmail.com> wrote: > >> Getting result of 3 would mean that anti pattern check and >> BuildWithHadoopVersions >> check failed. >> >> Echoing result at the end of each step is good. >> >> Cheers >> >> On Wed, Dec 2, 2015 at 7:48 PM, Apekshit Sharma <a...@cloudera.com> >> wrote: >> >> > I was staring at test-patch.sh for 15 minutes, but couldn't figure out >> what >> > could have been the error. Made sure that if any function was returning >> 1, >> > it was adding something JIRA_COMMENT. Tried to test it locally echoing >> > RESULT value after every test but it didn't help because our jenkins >> > environment used masters branch for some things. >> > I thought maybe someone else stumbled on it previously. >> > >> > Em..adding unique values may not be best. What if you get result of 3 >> (is >> > it 2+1 or 3). JIRA_COMMENT comment will be there of course, but... >> > Maybe we can echo the result value after every check? It'll go in >> console >> > logs anyway. >> > >> > >> > On Wed, Dec 2, 2015 at 7:35 PM, Ted Yu <yuzhih...@gmail.com> wrote: >> > >> > > -1 is given if value of $RESULT is not 0 : >> > > >> > > submitJiraComment $RESULT >> > > >> > > $RESULT is summation of return values of various checks: >> > > >> > > checkAntiPatterns >> > > (( RESULT = RESULT + $? )) >> > > checkBuildWithHadoopVersions >> > > (( RESULT = RESULT + $? )) >> > > ... >> > > >> > > Looks like $RESULT was non-zeron somehow. >> > > >> > > It was not clear which check returned non-zero value. >> > > >> > > One improvement we can make is to assign unique values for the checks. >> > > e.g. add 1 for anti pattern check, 2 for BuildWithHadoopVersions, 4 >> > > for JavacWarnings, etc >> > > >> > > Cheers >> > > >> > > On Wed, Dec 2, 2015 at 7:18 PM, Apekshit Sharma <a...@cloudera.com> >> > wrote: >> > > >> > > > Hi >> > > > Any ideas what can be the reason here? >> > > > >> > > > >> > > >> > >> https://issues.apache.org/jira/browse/HBASE-14865?focusedCommentId=15037056&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15037056 >> > > > >> > > > -- Appy >> > > > >> > > >> > >> > >> > >> > -- >> > >> > Regards >> > >> > Apekshit Sharma | Software Engineer, Cloudera | Palo Alto, California | >> > 650-963-6311 >> > >> > > > > -- > > Regards > > Apekshit Sharma | Software Engineer, Cloudera | Palo Alto, California | > 650-963-6311 > -- Regards Apekshit Sharma | Software Engineer, Cloudera | Palo Alto, California | 650-963-6311
