For anyone who's not following along on HBASE-14944, I added a comment based on the fine explanation provided by Andrew and the wording in our book. Unless there are objections, I will cary on with the release, including these changes. If you do have an objection, please speak up.
Thanks, Nick On Mon, Dec 7, 2015 at 1:57 PM, Andrew Purtell <[email protected]> wrote: > > > > So it's either EOL 1.0 (already intended) and 1.1 due to these security > bugs, > or ship a source-incompatible patch release? > > I opened HBASE-14944 for this > > > Is it not possible to provide default implementations of the new methods? > > We did. The addition of the new methods to the interfaces is what is > triggering the source compatibility warning. > > > On Mon, Dec 7, 2015 at 1:27 PM, Nick Dimiduk <[email protected]> wrote: > > > > > So it's either EOL 1.0 (already intended) and 1.1 due to these security > > bugs, or ship a source-incompatible patch release? The classes are all > > marked LimitedPrivate("coprocessors"), so the scope it's as wide as it > > could be. Is it not possible to provide default implementations of the > new > > methods? > > > > On Sun, Dec 6, 2015 at 4:55 PM, Andrew Purtell <[email protected] > > > > wrote: > > > > > > Reopened HBASE-14605, HBASE-14655, and HBASE-14631 as blockers for > > 1.1.x > > > and 1.0.x. > > > > > > I don't think we could leave the underlying problems with incorrect > user > > > context for security alone on branches 1.0 and 1.1 unfixed. We can > revert > > > this stuff - these changes are at the end of a cascade of changes > > stemming > > > from bug fixing - but then for sake of correct functioning of security > > > features we'd want to move people to 1.2. > > > > > > > > > > > > > On Dec 6, 2015, at 4:11 PM, Nick Dimiduk <[email protected]> > wrote: > > > > > > > > I found some source-incompatible changes in the compatibility report > > [0]. > > > > Reopened HBASE-14605, HBASE-14655, and HBASE-14631 as blockers for > > 1.1.x > > > > and 1.0.x. Since I'm asking, would be good to see the last mile > > > > on HBASE-14822 and HBASE-14844. > > > > > > > > [0]: > > > > > > > > > > http://home.apache.org/~ndimiduk/1.1.0_branch-1.1_compat_report.html#Type_Source_Problems_High > > > > > > > >> On Wed, Dec 2, 2015 at 1:17 PM, Nick Dimiduk <[email protected]> > > > wrote: > > > >> > > > >> With HBASE-14689 resolved, I plan to spin the next RC this weekend. > > Let > > > me > > > >> know if you have any concerns. > > > >> > > > >> -n > > > >> > > > >> On Tue, Nov 17, 2015 at 8:33 PM, Andrew Purtell < > > > [email protected]> > > > >> wrote: > > > >> > > > >>> Let's revert this from 0.98 even if the problem isn't manifesting > > there > > > >>> (or perhaps just not in the same way) > > > >>> > > > >>> > > > >>>> On Nov 17, 2015, at 7:33 PM, Enis Söztutar <[email protected]> > > > wrote: > > > >>>> > > > >>>> Sorry for the trouble, let me revert the commit. I'll look at the > > 0.98 > > > >>> RC > > > >>>> as well. > > > >>>> > > > >>>> > > > >>>> Enis > > > >>>> > > > >>>>> On Tue, Nov 17, 2015 at 7:32 PM, Enis Söztutar < > [email protected] > > > > > > >>> wrote: > > > >>>>> > > > >>>>> -1. > > > >>>>> > > > >>>>> I think this RC is also affected by HBASE-14689: > > > >>>>> > > > >>>>> > > > >>>>> A run of > > > >>>>> > > > >>>>> bin/hbase pe --latency --nomapred --presplit=10 --valueSize=10 > > > >>>>> randomWrite 10 > > > >>>>> > > > >>>>> results in client hang and a lot of following exceptions. > > > >>>>> > > > >>>>> Interesting that, I cannot reproduce this with LTT. > > > >>>>> > > > >>>>> java.io.IOException: Timed out waiting for lock for row: > > > >>> 00000000000000000000075868 > > > >>>>> at > > > >>> > > > > > > org.apache.hadoop.hbase.regionserver.HRegion.getRowLockInternal(HRegion.java:5088) > > > >>>>> at > > > >>> > > > > > > org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutation(HRegion.java:2980) > > > >>>>> at > > > >>> > > > > > > org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:2838) > > > >>>>> at > > > >>> > > > > > > org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:2780) > > > >>>>> at > > > >>> > > > > > > org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:692) > > > >>>>> at > > > >>> > > > > > > org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:654) > > > >>>>> at > > > >>> > > > > > > org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2036) > > > >>>>> at > > > >>> > > > > > > org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:32303) > > > >>>>> at > > org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2117) > > > >>>>> at > > org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:104) > > > >>>>> at > > > >>> > > > > > > org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:133) > > > >>>>> at > > > >>> org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:108) > > > >>>>> at java.lang.Thread.run(Thread.java:745) > > > >>>>> > > > >>>>> > > > >>>>> On Mon, Nov 16, 2015 at 8:35 PM, Andrew Purtell < > > [email protected] > > > > > > > >>>>> wrote: > > > >>>>> > > > >>>>>> +1 > > > >>>>>> > > > >>>>>> Checked signature and sums > > > >>>>>> Unpacked binary and source tarballs, contents look good > > > >>>>>> Built from source > > > >>>>>> RAT check passes > > > >>>>>> Loaded 1M rows with LoadTestTool, no unexpected log messages, > > > reported > > > >>>>>> latencies in line with expectations > > > >>>>>> Ran IntegrationTestBigLinkedList, no errors > > > >>>>>> > > > >>>>>> > > > >>>>>>> On Sun, Nov 8, 2015 at 8:54 PM, Nick Dimiduk < > > [email protected]> > > > >>> wrote: > > > >>>>>>> > > > >>>>>>> I'm happy to announce the first release candidate of HBase > 1.1.3 > > > >>>>>>> (HBase-1.1. > > > >>>>>>> 3RC0) is available for download at > > > >>>>>>> https://dist.apache.org/repos/dist/dev/hbase/hbase-1.1.3RC0/ > > > >>>>>>> > > > >>>>>>> Maven artifacts are also available in the staging repository > > > >>> > > https://repository.apache.org/content/repositories/orgapachehbase-1117 > > > >>>>>>> > > > >>>>>>> Artifacts are signed with my code signing subkey > > > 0xAD9039071C3489BD, > > > >>>>>>> available in the Apache keys directory > > > >>>>>>> https://people.apache.org/keys/committer/ndimiduk.asc > > > >>>>>>> > > > >>>>>>> There's also a signed tag for this release at > > > >>> > > > > > > https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=tag;h=16e905679e2dd5cb1b05ca8bc34a403e154a395f > > > >>>>>>> > > > >>>>>>> The detailed source and binary compatibility report vs 1.1.0 > has > > > been > > > >>>>>>> published for your review, at > > > >>>>>>> > > > http://people.apache.org/~ndimiduk/1.1.0_1.1.3RC0_compat_report.html > > > >>>>>>> > > > >>>>>>> HBase 1.1.3 is the third patch release in the HBase 1.1 line, > > > >>>>>> continuing on > > > >>>>>>> the theme of bringing a stable, reliable database to the Hadoop > > and > > > >>>>>> NoSQL > > > >>>>>>> communities. This release includes over 120 bug fixes since the > > > 1.1.2 > > > >>>>>>> release. Notable correctness fixes > > > >>>>>>> include HBASE-14474, HBASE-14591, HBASE-14224, > > > >>>>>>> HBASE-14431, HBASE-14407, HBASE-14313, HBASE-14621, > HBASE-14501, > > > and > > > >>>>>>> HBASE-13250. > > > >>>>>>> > > > >>>>>>> The full list of fixes included in this release is available at > > > >>> > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310753&version=12333152 > > > >>>>>>> and in the CHANGES.txt file included in the distribution. > > > >>>>>>> > > > >>>>>>> Please try out this candidate and vote +/-1 by 23:59 Pacific > time > > > on > > > >>>>>>> Friday, 2015-11-13 as to whether we should release these > > artifacts > > > as > > > >>>>>> HBase > > > >>>>>>> 1.1.3. > > > >>>>>>> > > > >>>>>>> Thanks, > > > >>>>>>> Nick > > > >>>>>> > > > >>>>>> > > > >>>>>> > > > >>>>>> -- > > > >>>>>> Best regards, > > > >>>>>> > > > >>>>>> - Andy > > > >>>>>> > > > >>>>>> Problems worthy of attack prove their worth by hitting back. - > > Piet > > > >>> Hein > > > >>>>>> (via Tom White) > > > >> > > > >> > > > > > > > > > -- > Best regards, > > - Andy > > Problems worthy of attack prove their worth by hitting back. - Piet Hein > (via Tom White) >
